Skip to content

package/mplayer: add optional dependencies

Yann E. MORIN buildroot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 of 18 patches 0 repliesNew

5 of 18 patches are in this archive. The cover letter announces 18.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
10/18package/mplayer: add optional lzo support+0 -00 replies
11/18package/mplayer: add optional faad2 support+0 -00 replies
12/18package/mplayer: add optional rtmpdump support+0 -01 reply
14/18package/mplayer: add optional libiconv support+0 -01 reply
18/18package/mplayer: add optional libmpeg2 support+0 -00 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchYann E. MORIN
10/18R-b
11/18R-b
12/18
14/18
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Buildroot] [PATCH 00/18] package/mplayer: add optional dependencies

Thomas, All,

On 2015-04-08 23:35 +0200, Thomas Petazzoni spake thusly:

Quoted 35 lines · Bernd Kuhls
Quoted 10 lines

package/mplayer: add optional lzo support package/mplayer: add optional faad2 support package/mplayer: add optional rtmpdump support package/mplayer: add optional speex support package/mplayer: add optional libiconv support package/mplayer: disable optional libcdio support package/mplayer: add optional bzip2 support package/mplayer: add optional lame support package/mplayer: add optional libmpeg2 support

I've applied those patches, after fixing up things to rely on autodection in order to avoid the "extra libs" thing.

However, I'm not entirely happy with how the mplayer package looks like. Some dependencies have explicit disable:

ifeq ($(BR2_PACKAGE_LAME),y)
MPLAYER_DEPENDENCIES += lame
MPLAYER_CONF_OPTS += --enable-mp3lame
else
MPLAYER_CONF_OPTS += --disable-mp3lame
endif

but some do not:

ifeq ($(BR2_PACKAGE_TREMOR),y)
MPLAYER_DEPENDENCIES += tremor
MPLAYER_CONF_OPTS += --disable-tremor-internal --enable-tremor endif

and for example, when --disable-tremor is not passed, an internal tremor implementation is used, as far as I can see.

Quoted 7 lines

There are also cases like:

MPLAYER_DEPENDENCIES += $(if $(BR2_PACKAGE_BZIP2),bzip2)

All of this should probably be harmonized to properly get an explicit disabling for all dependencies, unless there is a good reason not to do so.

Well, the reason is pretty obvious:

- it's not an autotools package, the configure is hand-written
- some options have explicit --enable/disable-foo
- some options only have --enable-foo
- and some only rely on detecting the optional lib(s)

For example, there's no option for bzip2: if the lib is present, it is enabled, otherwise it is disabled.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Read the cover letter in its thread