Skip to content

Allow to use leds-ns2 with n090401 boards

Simon Guinot linux-arm-kernel linux-devicetree linux-leds 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 0 repliesNew
  2. v1 posting 2/24 patches 0 repliesSuperseded
  3. v1 posting 1/20 of 4 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- Fix gpio_{get,set}_*_cansleep() usage while holding a spinlock:
Holding a spinlock at this places was not needed.
- Add Acked-by from Jacek Anaszewski for patch 4.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4leds: leds-ns2: move LED modes mapping outside of the driverDocumentation/devicetree/bindings/leds/leds-ns2.txt drivers/leds/leds-ns2.c include/dt-bindings/leds/leds-ns2.h +1 more+85 -480 replies
2/4ARM: Kirkwood: add modes-map property to ns2-leds nodesarch/arm/boot/dts/kirkwood-d2net.dts arch/arm/boot/dts/kirkwood-is2.dts arch/arm/boot/dts/kirkwood-ns2.dts +2 more+25 -03 replies
3/4leds: leds-ns2: handle can_sleep GPIOsdrivers/leds/leds-ns2.c+51 -240 replies
4/4leds: leds-ns2: depends on MACH_ARMADA_370drivers/leds/Kconfig+8 -40 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJacek AnaszewskiGregory CLEMENT
SeriesA-b
1/4
2/4A-b
3/4
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] Allow to use leds-ns2 with n090401 boards

Hello,

This patch series allows to use the leds-ns2 driver with the n090401 boards (Seagate NAS 4-Bay), based on an Armada-370 SoC.

Here is the list changes:

- Allow to configure the LED mode mapping.
- Handle can_sleep GPIOs. On n090401, the LEDs are connected to an I2C GPIO expander.
- Make leds-ns2 depends on MACH_ARMADA_370.

Changes for v2:
- Fix gpio_{get,set}_*_cansleep() usage while holding a spinlock:
Holding a spinlock at this places was not needed.
- Add Acked-by from Jacek Anaszewski for patch 4.

Simon

Simon Guinot (2):
leds: leds-ns2: handle can_sleep GPIOs
leds: leds-ns2: depends on MACH_ARMADA_370

Vincent Donnefort (2):
leds: leds-ns2: move LED modes mapping outside of the driver
ARM: Kirkwood: add modes-map property to ns2-leds nodes

 .../devicetree/bindings/leds/leds-ns2.txt          |   9 ++
 arch/arm/boot/dts/kirkwood-d2net.dts               |   5 +
 arch/arm/boot/dts/kirkwood-is2.dts                 |   5 +
 arch/arm/boot/dts/kirkwood-ns2.dts                 |   5 +
 arch/arm/boot/dts/kirkwood-ns2max.dts              |   5 +
 arch/arm/boot/dts/kirkwood-ns2mini.dts             |   5 +
 drivers/leds/Kconfig                               |  12 +-
 drivers/leds/leds-ns2.c                            | 169 ++++++++++++---------
 include/dt-bindings/leds/leds-ns2.h                |   8 +
 include/linux/platform_data/leds-kirkwood-ns2.h    |  14 ++
 10 files changed, 165 insertions(+), 72 deletions(-)
 create mode 100644 include/dt-bindings/leds/leds-ns2.h
Signature · 1 line
2.1.4