hrtimer (related) fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 14 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | hrtimer: Fix race between hrtimer_start() and __run_hrtimer()kernel/ | +9 | 10 replies | |
| 2/3 | sched: Cleanup bandwidth timerskernel/ kernel/ kernel/ +1 more | +31 | 1 reply | |
| 3/3 | perf: Fix mux_interval hrtimer wreckagekernel/ | +35 | 3 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by.
| Patch | Ben Segall | Peter Zijlstra (Intel) |
|---|---|---|
| 1/3 | Almost-Signed-off-by | |
| 2/3 | R-b | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] hrtimer (related) fixes
Hi Thomas,
I spoke to you about these patches/bugs a fair few months ago but never got around to properly fixing them. With your recent hrtimer work it got a lot simpler, thanks!
So here are 3 patches, the first of which fixes a hrtimer bug that should be much easier to expose after the next two patches.
The second one attempts to clean up some brainmelt in the CFS bandwidth timer; the 'problem' there is that do not want to loose either the timer or a period.
- one could loose the timer by observing it active and not (re)starting it while the callback had already decided to NORESTART.
- one could loose a period by having the restart forward the expiry time such that the handler would not observe the overrun and properly account for it.
This is now all solved by not forwarding the timer from (re)start when active and then unconditionally starting it. Yay for being able to start expired timers -- note that it should still be very rare, since when the timer is active it will most likely have just forwarded the expiry time from the handler.
But note that unconditionally starting the timer would have easily triggered the bug fixed by the first patch.
The third patch is an alternative to the perf patch you send out a few days ago; it got stuck in this queue because it too suffers from these problems, albeit at a much reduced risk because the code in question is 'never' triggered (as demonstrated by this fail being there forever).