Skip to content

signals: don't abuse __flush_signals() in selinux_bprm_committed_creds()

Oleg Nesterov kvm lkml selinux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1signals: don't abuse __flush_signals() in selinux_bprm_committed_creds()include/linux/sched.h kernel/signal.c security/selinux/hooks.c+8 -121 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] signals: don't abuse __flush_signals() in selinux_bprm_committed_creds()
Quoted 10 lines · Oleg Nesterov
Quoted 6 lines · Ingo Molnar

I also found a __flush_signals() use in:

security/selinux/hooks.c

and I simply can't understand this code... but I feel that it can't be correct ;) Will try to re-read tomorrow.

Yes, this doesn't look right. Lets kill __flush_signals() first, there are no other users.

And I am not sure it is fine to flush SIGSTOP... do we really want this?

Oleg.

Read the cover letter in its thread