Skip to content

2.6.32.66-longterm review

Willy Tarreau lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest47 of 48 patches 13 repliesIn review

47 of 48 patches are in this archive. The cover letter announces 48.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/48x86/asm/traps: Disable tracing and kprobes in fixup_bad_iret and sync_regsarch/x86/kernel/traps.c+2 -20 replies
2/48x86/tls: Validate TLS entries to protect espfixarch/x86/kernel/tls.c+23 -00 replies
3/48x86, tls, ldt: Stop checking lm in LDT_emptyarch/x86/include/asm/desc.h+2 -70 replies
4/48x86, tls: Interpret an all-zero struct user_desc as "no segment"arch/x86/include/asm/desc.h arch/x86/kernel/tls.c+36 -20 replies
5/48x86_64, switch_to(): Load TLS descriptors before switching DS and ESarch/x86/kernel/process_64.c+73 -289 replies
6/48x86/tls: Disallow unusual TLS segmentsarch/x86/kernel/tls.c+22 -00 replies
7/48x86/tls: Dont validate lm in set_thread_area() after allarch/x86/include/asm/ldt.h arch/x86/kernel/tls.c+7 -60 replies
8/48x86, kvm: Clear paravirt_enabled on KVM guests for espfix32s benefitarch/x86/kernel/kvm.c arch/x86/kernel/kvmclock.c+8 -20 replies
9/48x86_64, vdso: Fix the vdso address randomization algorithmarch/x86/vdso/vma.c+26 -101 reply
10/48ASLR: fix stack randomization on 64-bit systemsarch/x86/mm/mmap.c fs/binfmt_elf.c+6 -50 replies
11/48x86, cpu, amd: Add workaround for family 16h, erratum 793arch/x86/include/asm/msr-index.h arch/x86/kernel/cpu/amd.c+11 -00 replies
12/48x86/asm/entry/64: Remove a bogus ret_from_fork optimizationarch/x86/kernel/entry_64.S+8 -50 replies
13/48x86: Conditionally update time when ack-ing pending irqsarch/x86/kernel/apic/apic.c+7 -50 replies
14/48serial: samsung: wait for transfer completion before clock disabledrivers/serial/samsung.c+4 -00 replies
15/48splice: Apply generic position and size checks to each writefs/ocfs2/file.c fs/splice.c+12 -40 replies
16/48netfilter: conntrack: disable generic tracking for known protocolsnet/netfilter/nf_conntrack_proto_generic.c+25 -11 reply
17/48isofs: Fix infinite looping over CE entriesfs/isofs/rock.c+6 -00 replies
18/48isofs: Fix unchecked printing of ER recordsfs/isofs/rock.c+3 -00 replies
19/48net: sctp: fix memory leak in auth key managementnet/sctp/auth.c+0 -20 replies
20/48net: sctp: fix slab corruption from use after free on INIT collisionsnet/sctp/associola.c+0 -10 replies
21/48IB/uverbs: Prevent integer overflow in ib_umem_get address arithmeticdrivers/infiniband/core/umem.c+8 -00 replies
22/48net: llc: use correct size for sysctl timeout entriesnet/llc/sysctl_net_llc.c+4 -40 replies
23/48net: rds: use correct size for max unacked packets and bytesnet/rds/sysctl.c+2 -20 replies
24/48ipv6: Dont reduce hop limit for an interfacenet/ipv6/ndisc.c+8 -10 replies
25/48fs: take i_mutex during prepare_binprm for set[ug]id executablesfs/exec.c+40 -250 replies
26/48net:socket: set msg_namelen to 0 if msg_name is passed as NULL in msghdr struct from userland.net/socket.c+3 -02 replies
27/48ppp: deflate: never return len larger than output bufferdrivers/net/ppp_deflate.c+1 -10 replies
29/48net: reject creation of netdev names with colonsnet/core/dev.c+1 -10 replies
30/48ipv4: Dont use ufo handling on later transformed packetsnet/ipv4/ip_output.c+1 -00 replies
31/48udp: only allow UFO for packets from SOCK_DGRAM socketsnet/ipv4/ip_output.c net/ipv6/ip6_output.c+4 -30 replies
32/48net: avoid to hang up on sending due to sysctl configuration overflow.net/core/sysctl_net_core.c net/ipv4/sysctl_net_ipv4.c+23 -80 replies
33/48net: sysctl_net_core: check SNDBUF and RCVBUF for min lengthnet/core/sysctl_net_core.c+6 -50 replies
34/48rds: avoid potential stack overflownet/rds/iw_rdma.c+22 -180 replies
35/48rxrpc: bogus MSG_PEEK test in rxrpc_recvmsg()net/rxrpc/ar-recvmsg.c+1 -10 replies
36/48tcp: make connect() mem charging friendlynet/ipv4/tcp_output.c+2 -50 replies
37/48ip_forward: Drop frames with attached skb->sknet/ipv4/ip_forward.c+3 -00 replies
38/48tcp: avoid looping in tcp_send_fin()net/ipv4/tcp_output.c+26 -190 replies
39/48spi: spidev: fix possible arithmetic overflow for multi-transfer messagedrivers/spi/spidev.c+4 -10 replies
40/48IB/core: Avoid leakage from kernel to user spacedrivers/infiniband/core/uverbs_main.c+1 -00 replies
41/48ipvs: uninitialized data with IP_VS_IPV6net/netfilter/ipvs/ip_vs_ftp.c+5 -50 replies
42/48ipv4: fix nexthop attlen check in fib_nh_matchnet/ipv4/fib_semantics.c+1 -10 replies
43/48pagemap: do not leak physical addresses to non-privileged userspacefs/proc/task_mmu.c+10 -00 replies
44/48lockd: Try to reconnect if statd has movedfs/lockd/mon.c+6 -00 replies
45/48scsi: Fix error handling in SCSI_IOCTL_SEND_COMMANDblock/scsi_ioctl.c+1 -20 replies
46/48posix-timers: Fix stack info leak in timer_create()kernel/posix-timers.c+1 -00 replies
47/48hfsplus: fix B-tree corruption after insertion at position 0fs/hfsplus/brec.c+11 -90 replies
48/48sound/oss: fix deadlock in sequencer_ioctl(SNDCTL_SEQ_OUTOFBAND)sound/oss/sequencer.c+2 -100 replies

Reviews trailers per patch

15 of 47 patches have a Reviewed-by or Acked-by.

PatchThomas GleixnerAravind GopalakrishnanNeil HormanVlad YasevichSowmini VaradhanEric DumazetHannes Frederic SowaJozsef KadlecsikKees CookYuchung ChengH. Peter AnvinJulian AnastasovYann DroneaudCarl Henrik LundeKonstantin KhlebnikovAndy Lutomirski
1/48
2/48A-b
3/48
4/48
5/48
6/48A-b
7/48A-b
8/48
9/48R-b
10/48
11/48T-b
12/48
13/48A-b
14/48
15/48
16/48A-b
17/48
18/48Reported-and-tested-by
19/48A-b
20/48A-b A-b
21/48
22/48
23/48
24/48A-b
25/48
26/48
27/48
29/48
30/48
31/48
32/48
33/48
34/48A-b
35/48
36/48A-b
37/48
38/48
39/48
40/48R-b
41/48A-b
42/48A-b
43/48A-b A-b
44/48
45/48
46/48
47/48
48/48

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 16 reviewers.

Read the v1 thread

Cover letter [ 00/48] 2.6.32.66-longterm review

This is the start of the longterm review cycle for the 2.6.32.66 release. All patches will be posted as a response to this one. If anyone has any issue with these being applied, please let me know. If anyone is a maintainer of the proper subsystem, and wants to add a Signed-off-by: line to the patch, please respond with it. If anyone thinks some important patches are missing and should be added prior to the release, please report them quickly with their respective mainline commit IDs.

Responses should be made by Thu May 21 10:05:29 CEST 2015. Anything received after that time might be too late. If someone wants a bit more time for a deeper review, please let me know.

NOTE: 2.6.32 is approaching end of support. There will probably be one or maybe two other versions issued in the next 3-6 months, and that will be all, at least for me. Adding to this the time it can take to validate and deploy in some environments, it probably makes sense to start to think about switching to another longterm branch. 3.2 and 3.4 are good candidates for those seeking rock-solid versions. Longterm branches and their projected EOLs are listed here :

https://www.kernel.org/category/releases.html

The whole patch series can be found in one patch at :

     https://kernel.org/pub/linux/kernel/v2.6/longterm-review/patch-2.6.32.66-rc1.gz

The shortlog and diffstat are appended below.

Thanks,
Willy

===============

Al Viro (1):
rxrpc: bogus MSG_PEEK test in rxrpc_recvmsg()

Alexey Khoroshilov (1):
sound/oss: fix deadlock in sequencer_ioctl(SNDCTL_SEQ_OUTOFBAND)

Alexey Kodanev (1):
net: sysctl_net_core: check SNDBUF and RCVBUF for min length

Andy Lutomirski (10):
x86/asm/traps: Disable tracing and kprobes in fixup_bad_iret and sync_regs x86/tls: Validate TLS entries to protect espfix
x86, tls, ldt: Stop checking lm in LDT_empty
x86, tls: Interpret an all-zero struct user_desc as "no segment" x86_64, switch_to(): Load TLS descriptors before switching DS and ES x86/tls: Disallow unusual TLS segments
x86/tls: Don't validate lm in set_thread_area() after all x86, kvm: Clear paravirt_enabled on KVM guests for espfix32's benefit x86_64, vdso: Fix the vdso address randomization algorithm x86/asm/entry/64: Remove a bogus 'ret_from_fork' optimization

Ani Sinha (1):
net:socket: set msg_namelen to 0 if msg_name is passed as NULL in msghdr struct from userland.

Arnd Bergmann (1):
rds: avoid potential stack overflow

Ben Hutchings (1):
splice: Apply generic position and size checks to each write

Benjamin Coddington (1):
lockd: Try to reconnect if statd has moved

Borislav Petkov (1):
x86, cpu, amd: Add workaround for family 16h, erratum 793

D.S. Ljungmark (1):
ipv6: Don't reduce hop limit for an interface

Dan Carpenter (1):
ipvs: uninitialized data with IP_VS_IPV6

Daniel Borkmann (2):
net: sctp: fix memory leak in auth key management
net: sctp: fix slab corruption from use after free on INIT collisions

Eli Cohen (1):
IB/core: Avoid leakage from kernel to user space

Eric Dumazet (2):
tcp: make connect() mem charging friendly
tcp: avoid looping in tcp_send_fin()

Florian Westphal (2):
netfilter: conntrack: disable generic tracking for known protocols
ppp: deflate: never return len larger than output buffer

Hector Marco-Gisbert (1):
ASLR: fix stack randomization on 64-bit systems

Ian Abbott (1):
spi: spidev: fix possible arithmetic overflow for multi-transfer message

Ignacy Gawędzki (1):
ematch: Fix auto-loading of ematch modules.

Jan Kara (3):
isofs: Fix infinite looping over CE entries
isofs: Fix unchecked printing of ER records
scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND

Jann Horn (1):
fs: take i_mutex during prepare_binprm for set[ug]id executables

Jiri Pirko (1):
ipv4: fix nexthop attlen check in fib_nh_match

Kirill A. Shutemov (1):
pagemap: do not leak physical addresses to non-privileged userspace

Mathias Krause (1):
posix-timers: Fix stack info leak in timer_create()

Matthew Thode (1):
net: reject creation of netdev names with colons

Michal Kubeček (1):
udp: only allow UFO for packets from SOCK_DGRAM sockets

Robert Baldyga (1):
serial: samsung: wait for transfer completion before clock disable

Sasha Levin (2):
net: llc: use correct size for sysctl timeout entries
net: rds: use correct size for max unacked packets and bytes

Sebastian P�hn (1):

      ip_forward: Drop frames with attached skb->sk

Sergei Antonov (1):
hfsplus: fix B-tree corruption after insertion at position 0

Shachar Raindel (1):
IB/uverbs: Prevent integer overflow in ib_umem_get address arithmetic

Shai Fultheim (1):
x86: Conditionally update time when ack-ing pending irqs

Steffen Klassert (1):
ipv4: Don't use ufo handling on later transformed packets

[email protected] (1):
net: avoid to hang up on sending due to sysctl configuration overflow.

 arch/x86/include/asm/desc.h                |  20 ++++--
 arch/x86/include/asm/ldt.h                 |   7 ++
 arch/x86/include/asm/msr-index.h           |   1 +
 arch/x86/kernel/apic/apic.c                |  12 ++--
 arch/x86/kernel/cpu/amd.c                  |  10 +++
 arch/x86/kernel/entry_64.S                 |  13 ++--
 arch/x86/kernel/kvm.c                      |   9 ++-
 arch/x86/kernel/kvmclock.c                 |   1 -
 arch/x86/kernel/process_64.c               | 101 +++++++++++++++++++++--------
 arch/x86/kernel/tls.c                      |  62 +++++++++++++++++-
 arch/x86/kernel/traps.c                    |   4 +-
 arch/x86/mm/mmap.c                         |   6 +-
 arch/x86/vdso/vma.c                        |  36 +++++++---
 block/scsi_ioctl.c                         |   3 +-
 drivers/infiniband/core/umem.c             |   8 +++
 drivers/infiniband/core/uverbs_main.c      |   1 +
 drivers/net/ppp_deflate.c                  |   2 +-
 drivers/serial/samsung.c                   |   4 ++
 drivers/spi/spidev.c                       |   5 +-
 fs/binfmt_elf.c                            |   5 +-
 fs/exec.c                                  |  65 ++++++++++++-------
 fs/hfsplus/brec.c                          |  20 +++---
 fs/isofs/rock.c                            |   9 +++
 fs/lockd/mon.c                             |   6 ++
 fs/ocfs2/file.c                            |   8 ++-
 fs/proc/task_mmu.c                         |  10 +++
 fs/splice.c                                |   8 ++-
 kernel/posix-timers.c                      |   1 +
 net/core/dev.c                             |   2 +-
 net/core/sysctl_net_core.c                 |  19 ++++--
 net/ipv4/fib_semantics.c                   |   2 +-
 net/ipv4/ip_forward.c                      |   3 +
 net/ipv4/ip_output.c                       |   3 +-
 net/ipv4/sysctl_net_ipv4.c                 |  13 ++--
 net/ipv4/tcp_output.c                      |  52 ++++++++-------
 net/ipv6/ip6_output.c                      |   3 +-
 net/ipv6/ndisc.c                           |   9 ++-
 net/llc/sysctl_net_llc.c                   |   8 +--
 net/netfilter/ipvs/ip_vs_ftp.c             |  10 +--
 net/netfilter/nf_conntrack_proto_generic.c |  26 +++++++-
 net/rds/iw_rdma.c                          |  40 +++++++-----
 net/rds/sysctl.c                           |   4 +-
 net/rxrpc/ar-recvmsg.c                     |   2 +-
 net/sched/ematch.c                         |   1 +
 net/sctp/associola.c                       |   1 -
 net/sctp/auth.c                            |   2 -
 net/socket.c                               |   3 +
 sound/oss/sequencer.c                      |  12 +---
 48 files changed, 465 insertions(+), 187 deletions(-)

--