Skip to content

hrtimer: HRTIMER_STATE_ fixes

Oleg Nesterov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hrtimer: kill HRTIMER_STATE_MIGRATE, fix the race with hrtimer_is_queued()include/linux/hrtimer.h kernel/time/hrtimer.c+3 -101 reply
1/3hrtimer: kill HRTIMER_STATE_MIGRATE, fix the race with hrtimer_is_queued()include/linux/hrtimer.h kernel/time/hrtimer.c+3 -100 replies
2/3hrtimer: turn newstate arg of __remove_hrtimer() into clear_enqueuedkernel/time/hrtimer.c+9 -100 replies
3/3hrtimer: fix the __hrtimer_start_range_ns() race with hrtimer_active()kernel/time/hrtimer.c+5 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] hrtimer: HRTIMER_STATE_ fixes
Quoted 6 lines · Peter Zijlstra
Quoted 3 lines

I tend to agree, but I think its a pre-existing problem, not one introduced by my proposed patch.

Something like this would fix that I think. It fully preserves timer->state over hrtimer_start_range_ns().

Yes, but I think we can do a bit better.

Only for initial review, I need to re-check this...

And. I think that after you remove STATE_CALLBACK we can even kill timer->state altogether, but this is another story.

What do you think?

Oleg.