Skip to content

xen: sched / cpupool: fixes and improvements, mostly for when suspend/resume is involved

Dario Faggioli xen-devel 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 0 repliesNew
  2. v14 patches 17 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4xen: sched: avoid dumping duplicate informationxen/common/cpupool.c xen/common/schedule.c+16 -80 replies
2/4xen: x86 / cpupool: clear the proper cpu_valid bit on pCPU teardownxen/arch/x86/smpboot.c xen/common/cpupool.c+2 -10 replies
3/4xen: credit1: properly deal with pCPUs not in any cpupoolxen/common/sched_credit.c xen/common/sched_sedf.c+18 -80 replies
4/4xen: sched: get rid of cpupool_scheduler_cpumask()xen/common/domain.c xen/common/domctl.c xen/common/sched_arinc653.c +5 more+27 -200 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchJuergen GrossGeorge DunlapAndrew CooperJoshua WhiteheadMeng Xu
1/4A-b A-b
2/4A-b A-b
3/4A-b R-b
4/4A-b A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/4] xen: sched / cpupool: fixes and improvements, mostly for when suspend/resume is involved

Hello,

Take 2 of this series:
http://lists.xenproject.org/archives/html/xen-devel/2015-06/msg04137.html

There has not been much to do wrt v1, and the series has all the acks it requires, IMO, with (maybe, see below) the exception of patch 4.

Basically, I improved the changelog of patch 2, as Andrew requested, and I made the adjustemed to patch 4 that George Suggested (for more details, check the changelogs).

About patch 4: formally, it's missing George's ack. His comments to the patch are here:
http://osdir.com/ml/general/2015-07/msg02413.html

He gave a few suggestions, explicitly stating that no action was required. He also made a comment at the bottom, which I incorporated in this new version. However, he did not formally state that, with that change, I could consider the patch acked, so, although it looked like so, I did not put the tag in there.

I guess it will be up to the committers to judge, or we can just wait for Monday, or whenever George will have time to look at this again. In fact, I'm not saying all this to push or anything, I just wanted to provide a clear picture of the situation. :-)

There is a git branch with this version of the series here:

git://xenbits.xen.org/people/dariof/xen.git rel/cpupool/sched-fixes-v2
http://xenbits.xen.org/gitweb/?p=people/dariof/xen.git;a=shortlog;h=refs/heads/rel/cpupool/sched-fixes-v2

If the SEDF removal series goes in before this, I've preparred a branch with this series stacked on top of the SEDF one, in case it helps (of course, I can just rebase and resubmit, no big deal):

git://xenbits.xen.org/people/dariof/xen.git tmp/nosedf_cpupsched
http://xenbits.xen.org/gitweb/?p=people/dariof/xen.git;a=shortlog;h=refs/heads/tmp/nosedf_cpupsched

Thnaks and Regards,
Dario
---
Dario Faggioli (4):
xen: sched: avoid dumping duplicate information
xen: x86 / cpupool: clear the proper cpu_valid bit on pCPU teardown
xen: credit1: properly deal with pCPUs not in any cpupool
xen: sched: get rid of cpupool_scheduler_cpumask()

 xen/arch/x86/smpboot.c      |    1 -
 xen/common/cpupool.c        |    8 +++++---
 xen/common/domain.c         |    5 +++--
 xen/common/domctl.c         |    4 ++--
 xen/common/sched_arinc653.c |    2 +-
 xen/common/sched_credit.c   |   25 ++++++++++++++++---------
 xen/common/sched_rt.c       |   12 ++++++------
 xen/common/sched_sedf.c     |    5 +++--
 xen/common/schedule.c       |   20 ++++++++++++++------
 xen/include/xen/sched-if.h  |   12 ++++++++++--
 10 files changed, 60 insertions(+), 34 deletions(-)

--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)