sb_write: lockdep fixes/cleanups
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | introduce __sb_{acquire,release}_write() helpersfs/ fs/ include/ | +9 | 1 reply | |
| 2/4 | fix the broken lockdep logic in __sb_start_write()fs/ | +40 | 2 replies | |
| 3/4 | move rwsem_release() from sb_wait_write() to freeze_super()fs/ | +10 | 1 reply | |
| 4/4 | change thaw_super() to re-acquire s_writers.lock_mapfs/ | +12 | 1 reply |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Jan Kara |
|---|---|
| 1/4 | R-b |
| 2/4 | R-b |
| 3/4 | R-b |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4] sb_write: lockdep fixes/cleanups
So this is the preparation for percpu_rw_semaphore conversion. But let me repeat, imo these changes make sense in any case, so I'd like to send them separately.
2/4 fixes 2 bugs and cleanups the "trylock" hack. Although this hack can be probably removed, see the changelog.
3/4 and 4/4 try to make the lockdep annotations more consistent. If we want to use lockdep we should not hide the "write" locks we hold when we call freeze_fs(sb) and unfreeze_fs(sb).
Please review.
Oleg.
fs/btrfs/transaction.c | 8 +--- fs/super.c | 101 +++++++++++++++++++++++++++++------------------ fs/xfs/xfs_aops.c | 6 +-- include/linux/fs.h | 5 ++ 4 files changed, 71 insertions(+), 49 deletions(-)