Skip to content

add dfu support for at91 sam9260 based boards

Marek Vasut u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 of 3 patches 0 repliesNew

2 of 3 patches are in this archive. The cover letter announces 3.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ARM: at91: add cpu.h+0 -00 replies
3/3at91, taurus, smartweb: add dfu support+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/3] add dfu support for at91 sam9260 based boards
Quoted 20 lines · Lukasz Majewski

Hi Marek,

Quoted 18 lines

add dfu supprt for at91 sam9260 based boards. The USB gadget driver is ported from linux:

b2ba27a5c56ff: usb: gadget: at91_udc: move prepare clk into process context

it drops a lot of checkpatch warnings/errors:

checkpatch.pl found 12 error(s), 31 warning(s), 43 checks(s)

but for further updates I did not fix them.
The errors are all from this sort:

error: drivers/usb/gadget/at91_udc.c,87: space prohibited before open square bracket '['

a lot of "line over 80 characters" warnings ...

Quoted 8 lines
Quoted 4 lines

Heiko Schocher (3):
ARM: at91: add cpu.h
usb: gadget: at91_udc: add support for at91_udc
at91, taurus, smartweb: add dfu support

Marek, do you plan to review this patch series?

(I would need at least one review before I pull the code).

I took a brief look. One thing I don't quite like is the omnipresent #ifdef __UBOOT__ stuff. I'd much rather love to see some kind of a porting layer so the driver can just be picked from linux as-is, but that might be too much hassle.

Otherwise, I'm fine with it, though I nitpicked a bit.

Best regards,
Marek Vasut