sunxi: support FEL-provided environment vars and "fel" boot target
Get series with b4
b4 am 20150916043431.3e9fe7d9@i7Versions newest first · linked by author and title
- v2 Latest3 patches 0 repliesNew
- v11 patch 0 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | sunxi: (mksunxiboot) signature to indicate "sunxi" SPL variant | +0 | 0 replies | |
| 2/3 | sunxi: retrieve FEL-provided values to environment variables | +0 | 1 reply | |
| 3/3 | sunxi: add "fel" boot target | +0 | 0 replies |
Reviews trailers per patch
2 of 3 patches have a Reviewed-by or Acked-by.
| Patch | Siarhei Siamashka |
|---|---|
| 1/3 | A-b |
| 2/3 | |
| 3/3 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [U-Boot] [PATCH v2 0/3] sunxi: support FEL-provided environment vars and "fel" boot target
Quoted 54 lines · On Mon, 14 Sep 2015 16:12:25 +0200 Hans de Goede <[email protected]> wrote:
Hi,
Quoted 46 lines · Bernhard Nortmann
This patch series builds upon
http://lists.denx.de/pipermail/u-boot/2015-September/226515.html
http://lists.denx.de/pipermail/u-boot/2015-September/226688.htmlv2 combines the previous submissions, and adds some suggested fixes/changes.
The sunxi-tool side of things is discussed here:
https://www.mail-archive.com/linux-sunxi at googlegroups.com/msg13071.html* Hans de Goede already pointed out that it might be preferable to make use of the
spl_boot_device()function even from the main (non-SPL) U-Boot binary (e.g. for the "NAND" case). Currently this function is only available withCONFIG_SPL_BUILDset, and implemented inarch/arm/cpu/armv7/sunxi/board.c
Would it be safe to enable it for non-SPL builds and use something like "(spl_boot_device==BOOT_DEVICE_BOARD)" formisc_init_r()?* Side note: the sunxi
spl_boot_device()will probably require some future refinement anyway, to account for the 'oddball' A80. That SoC requires the SPL at a different address (0x10000instead of0x0).* The test for FEL boot mode ("eGON.BT0") in
spl_boot_device()explicitly uses the "io" functionreadl()to access the signature. Is there a specific reason for this? Marex pointed out (on IRC) that the SRAM might as well be read directly. For now, I have followed the existing code, and usedreadl()andreadb()to work with the SPL header information.* The
check_signature()function somewhat duplicates very similar code fromarch/arm/include/asm/io.h. That particular piece of code depends on the presence of a "__mem_pci" symbol. However, it seems 'generic' enough - so it may be worth to factor out and reuse it?Regards, B. Nortmann
Changes in v2:
- Rename field tofel_script_address, discardfel_data_size
- Clearing header fields is no longer needed, asmksunxiboot.czeroes entire image first
- renamedfel_data_addrtofel_script_addr, discardedfel_data_size
- make sure that FEL-related environment vars are always cleared first
- support minimum and maximum SPL (header) version, more verbose error messages
- renamedfel_data_addrtofel_scriptaddr
- combined both tests into one as suggested by Hans de GoedeQuoted 4 lines
Bernhard Nortmann (3):
sunxi: (mksunxiboot) signature to indicate "sunxi" SPL variant
sunxi: retrieve FEL-provided values to environment variables
sunxi: add "fel" boot target
Quoted 4 lines
Thanks, series looks good to me. Siarhei, can I have your Acked-by for this series (indicating that you are ok with them from having matching changes in sunxi-tools pov) ? Once I've your acked by I'll queue this up for merging.
Yes, it also looks good to me after the 'fel_data_size' field has been dropped.
Quoted 4 lines
Should we target this for v2015.10, or for the next cycle ?
The changes look quite safe to me, so I'm ok with putting this on v2015.10, but I wonder what others think.
I don't have any strong opinion about this.
Signature · 2 lines
Best regards, Siarhei Siamashka