RFC Network stack, first user of SLAB/kmem_cache bulk free API.
Get series with b4
b4 am 20150904165944.4312.32435.stgit@devilVersions newest first
- v1 RFC Latest0 of 3 patches 14 repliesIn review
Patches in v1 No applies recorded yet
None of the 3 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 0/3] Network stack, first user of SLAB/kmem_cache bulk free API.
During TX DMA completion cleanup there exist an opportunity in the NIC drivers to perform bulk free, without introducing additional latency.
For an IPv4 forwarding workload the network stack is hitting the slowpath of the kmem_cache "slub" allocator. This slowpath can be mitigated by bulk free via the detached freelists patchset.
Depend on patchset:
http://thread.gmane.org/gmane.linux.kernel.mm/137469
Kernel based on MMOTM tag 2015-08-24-16-12 from git repo:
git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git
Also contains Christoph's patch "slub: Avoid irqoff/on in bulk allocation"
Benchmarking: Single CPU IPv4 forwarding UDP (generator pktgen):
* Before: 2043575 pps
* After : 2090522 pps
* Improvements: +46947 pps and -10.99 ns
In the before case, perf report shows slub free hits the slowpath:
1.98% ksoftirqd/6 [kernel.vmlinux] [k] __slab_free.isra.72 1.29% ksoftirqd/6 [kernel.vmlinux] [k] cmpxchg_double_slab.isra.71 0.95% ksoftirqd/6 [kernel.vmlinux] [k] kmem_cache_free 0.95% ksoftirqd/6 [kernel.vmlinux] [k] kmem_cache_alloc 0.20% ksoftirqd/6 [kernel.vmlinux] [k] __cmpxchg_double_slab.isra.60 0.17% ksoftirqd/6 [kernel.vmlinux] [k] ___slab_alloc.isra.68 0.09% ksoftirqd/6 [kernel.vmlinux] [k] __slab_alloc.isra.69
After the slowpath calls are almost gone:
0.22% ksoftirqd/6 [kernel.vmlinux] [k] __cmpxchg_double_slab.isra.60 0.18% ksoftirqd/6 [kernel.vmlinux] [k] ___slab_alloc.isra.68 0.14% ksoftirqd/6 [kernel.vmlinux] [k] __slab_free.isra.72 0.14% ksoftirqd/6 [kernel.vmlinux] [k] cmpxchg_double_slab.isra.71 0.08% ksoftirqd/6 [kernel.vmlinux] [k] __slab_alloc.isra.69
Extra info, tuning SLUB per CPU structures gives further improvements:
* slub-tuned: 2124217 pps
* patched increase: +33695 pps and -7.59 ns
* before increase: +80642 pps and -18.58 ns
Tuning done:
echo 256 > /sys/kernel/slab/skbuff_head_cache/cpu_partial
echo 9 > /sys/kernel/slab/skbuff_head_cache/min_partial
Without SLUB tuning, same performance comes with kernel cmdline "slab_nomerge":
* slab_nomerge: 2121824 pps
Test notes:
* Notice very fast CPU i7-4790K CPU @ 4.00GHz
* gcc version 4.8.3 20140911 (Red Hat 4.8.3-9) (GCC)
* kernel 4.1.0-mmotm-2015-08-24-16-12+ #271 SMP
* Generator pktgen UDP single flow (pktgen_sample03_burst_single_flow.sh)
* Tuned for forwarding:
- unloaded netfilter modules
- Sysctl settings:
- net/ipv4/conf/default/rp_filter = 0
- net/ipv4/conf/all/rp_filter = 0
- (Forwarding performance is affected by early demux)
- net/ipv4/ip_early_demux = 0
- net.ipv4.ip_forward = 1
- Disabled GRO on NICs
- ethtool -K ixgbe3 gro off tso off gso off
---
Jesper Dangaard Brouer (3):
net: introduce kfree_skb_bulk() user of kmem_cache_free_bulk()
net: NIC helper API for building array of skbs to free
ixgbe: bulk free SKBs during TX completion cleanup cycle
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 13 +++- include/linux/netdevice.h | 62 ++++++++++++++++++ include/linux/skbuff.h | 1 net/core/skbuff.c | 87 ++++++++++++++++++++----- 4 files changed, 144 insertions(+), 19 deletions(-)
--