Skip to content

selftests/pstore: add pstore test script

Hiraku Toyooka linux-api lkml 2 versions – In review

Get series with b4
b4 am 20151002114637.20957.61769.stgit@arietta

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesIn review
  2. v12 patches 13 repliesSuperseded

Changes in v2 from the cover letter

* Exit with 1 in pstore/Makefile when pstore_crash_test failed.
* Create helper functions to make the tests much more readable.
* Use /sys/module/pstore/parameters/backend to check pstore backend is registered.
* Show content of /sys/module/.../backend and /proc/cmdline for debug
* Give UUID to each execution of test script.
* Write unique test string with UUID into pmsg.
* Check only one test string pattern appears in pmsg after crash.
* Check UUID written to pmsg matches across crash.
* Don't touch panic_on_oops because it is not necessary for reboot on crash

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2selftests/pstore: add pstore test script for pre-reboottools/testing/selftests/Makefile tools/testing/selftests/pstore/Makefile tools/testing/selftests/pstore/common_tests +1 more+98 -01 reply
2/2selftests/pstore: add pstore test scripts going with reboottools/testing/selftests/Makefile tools/testing/selftests/pstore/Makefile tools/testing/selftests/pstore/common_tests +2 more+143 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] selftests/pstore: add pstore test script

These scripts include test cases which check pstore behavior. This is useful to avoid regressions of pstore.

Changes since v1:
* Exit with 1 in pstore/Makefile when pstore_crash_test failed.
* Create helper functions to make the tests much more readable.
* Use /sys/module/pstore/parameters/backend to check pstore backend is registered.
* Show content of /sys/module/.../backend and /proc/cmdline for debug
* Give UUID to each execution of test script.
* Write unique test string with UUID into pmsg.
* Check only one test string pattern appears in pmsg after crash.
* Check UUID written to pmsg matches across crash.
* Don't touch panic_on_oops because it is not necessary for reboot on crash

(v1: http://www.kernelhub.org/?msg=831044&p=2)

I also confirmed that these scripts work fine with kdump reboot with kernel boot parameter 'crash_kexec_post_notifiers'.

---

Hiraku Toyooka (2):
selftests/pstore: add pstore test script for pre-reboot selftests/pstore: add pstore test scripts going with reboot

 tools/testing/selftests/Makefile                   |    4 +
 tools/testing/selftests/pstore/Makefile            |   15 ++++
 tools/testing/selftests/pstore/common_tests        |   83 ++++++++++++++++++++
 tools/testing/selftests/pstore/pstore_crash_test   |   30 +++++++
 .../selftests/pstore/pstore_post_reboot_tests      |   77 +++++++++++++++++++
 tools/testing/selftests/pstore/pstore_tests        |   30 +++++++
 6 files changed, 239 insertions(+)
 create mode 100644 tools/testing/selftests/pstore/Makefile
 create mode 100755 tools/testing/selftests/pstore/common_tests
 create mode 100755 tools/testing/selftests/pstore/pstore_crash_test
 create mode 100755 tools/testing/selftests/pstore/pstore_post_reboot_tests
 create mode 100755 tools/testing/selftests/pstore/pstore_tests

--
Hiraku Toyooka