Skip to content

staging: lustre: fix (non-)static symbols issues

Anton Gerasimov lustre-devel 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v13 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging: lustre: moved extern declarations to a headerdrivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c drivers/staging/lustre/lustre/ptlrpc/nrs.c drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h +1 more+6 -40 replies
2/3staging: lustre: include header with local ptlrpc declarationsdrivers/staging/lustre/lustre/ptlrpc/sec_null.c drivers/staging/lustre/lustre/ptlrpc/wiretest.c+4 -00 replies
3/3staging: lustre: make non-exported functions staticdrivers/staging/lustre/lustre/ptlrpc/pack_generic.c+4 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [lustre-devel] [PATCHv2 0/3] staging: lustre: fix (non-)static symbols issues

This series of patches eliminates some sparse warnings concerning static variables in lustre rtlrpc module where it seemed reasonable. Symbols that are really local to a source file are made static and declarations added to a header for symbols that are shared between source files.

v2: Thank Andreas Dilger for the review.

Anton Gerasimov (3):
staging: lustre: moved extern declarations to a header
staging: lustre: include header with local ptlrpc declarations
staging: lustre: make non-exported functions static

 drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c    | 1 -
 drivers/staging/lustre/lustre/ptlrpc/nrs.c             | 1 -
 drivers/staging/lustre/lustre/ptlrpc/pack_generic.c    | 8 ++++----
 drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 6 ++++++
 drivers/staging/lustre/lustre/ptlrpc/ptlrpc_module.c   | 2 --
 drivers/staging/lustre/lustre/ptlrpc/sec_null.c        | 2 ++
 drivers/staging/lustre/lustre/ptlrpc/wiretest.c        | 2 ++
 7 files changed, 14 insertions(+), 8 deletions(-)
Signature · 1 line
2.5.1