x86: Memory Protection Keys
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest25 patches 17 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/25 | x86, fpu: add placeholder for Processor Trace XSAVE statearch/ arch/ | +9 | 1 reply | |
| 2/25 | x86, pkeys: Add Kconfig optionarch/ | +4 | 1 reply | |
| 3/25 | x86, pkeys: cpuid bit definitionarch/ arch/ arch/ +1 more | +50 | 1 reply | |
| 4/25 | x86, pku: define new CR4 bitarch/ | +2 | 1 reply | |
| 5/25 | x86, pkey: add PKRU xsave fields and data structure(s)arch/ arch/ arch/ | +25 | 2 replies | |
| 6/25 | x86, pkeys: PTE bits for storing protection keyarch/ | +16 | 1 reply | |
| 7/25 | x86, pkeys: new page fault error code bit: PF_PKarch/ | +6 | 2 replies | |
| 8/25 | x86, pkeys: store protection in high VMA flagsarch/ include/ mm/ | +11 | 0 replies | |
| 9/25 | x86, pkeys: arch-specific protection bitsarch/ arch/ arch/ +1 more | +52 | 0 replies | |
| 10/25 | x86, pkeys: pass VMA down in to fault signal generation codearch/ | +28 | 0 replies | |
| 11/25 | x86, pkeys: notify userspace about protection key faultsarch/ arch/ include/ +1 more | +79 | 0 replies | |
| 12/25 | x86, pkeys: add functions to fetch PKRUarch/ arch/ | +28 | 0 replies | |
| 13/25 | mm: factor out VMA fault permission checkingmm/ | +12 | 0 replies | |
| 14/25 | mm: simplify get_user_pages() PTE bit handlingarch/ | +17 | 0 replies | |
| 15/25 | x86, pkeys: check VMAs and PTEs for protection keysarch/ arch/ arch/ +7 more | +165 | 4 replies | |
| 16/25 | x86, pkeys: optimize fault handling in access_error()arch/ | +10 | 0 replies | |
| 17/25 | x86, pkeys: dump PKRU with other kernel registersarch/ | +2 | 0 replies | |
| 18/25 | x86, pkeys: dump PTE pkey in /proc/pid/smapsarch/ fs/ | +14 | 0 replies | |
| 19/25 | x86, pkeys: add Kconfig prompt to existing config optionarch/ | +10 | 0 replies | |
| 20/25 | mm, multi-arch: pass a protection key in to calc_vm_flag_bits()arch/ drivers/ drivers/ +4 more | +15 | 0 replies | |
| 21/25 | mm: implement new mprotect_key() system callmm/ mm/ | +24 | 2 replies | |
| 22/25 | x86: wire up mprotect_key() system callarch/ arch/ arch/ +1 more | +10 | 0 replies | |
| 23/25 | x86, pkeys: actually enable Memory Protection Keys in CPUDocumentation/ arch/ | +44 | 0 replies | |
| 24/25 | x86, pkeys: add self-teststools/ tools/ tools/ | +1011 | 0 replies | |
| 25/25 | x86, pkeys: DocumentationDocumentation/ | +54 | 2 replies |
Reviews trailers per patch
6 of 25 patches have a Reviewed-by or Acked-by.
| Patch | Dave Hansen | Thomas Gleixner |
|---|---|---|
| 1/25 | R-b | |
| 2/25 | R-b | |
| 3/25 | R-b | |
| 4/25 | R-b | |
| 5/25 | ||
| 6/25 | R-b | |
| 7/25 | R-b | |
| 8/25 | ||
| 9/25 | ||
| 10/25 | ||
| 11/25 | ||
| 12/25 | eigned-off-by | |
| 13/25 | ||
| 14/25 | ||
| 15/25 | ||
| 16/25 | ||
| 17/25 | ||
| 18/25 | ||
| 19/25 | ||
| 20/25 | ||
| 21/25 | ||
| 22/25 | ||
| 23/25 | ||
| 24/25 | ||
| 25/25 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/25] x86: Memory Protection Keys
I have addressed all known issues and review comments. I believe they are ready to be pulled in to the x86 tree. Note that this is also the first time anyone has seen the new 'selftests' code. If there are issues limited to it, I'd prefer to fix those up separately post-merge.
Changes from RFCv2 (Thanks Ingo and Thomas for most of these):
* few minor compile warnings
* changed 'nopku' interaction with cpuid bits. Now, we do not clear the PKU cpuid bit, we just skip enabling it.
* changed __pkru_allows_write() to also check access disable bit
* removed the unused write_pkru()
* made si_pkey a u64 and added some patch description details. Also made it share space in siginfo with MPX and clarified comments.
* give some real text for the Processor Trace xsave state
* made vma_pkey() less ugly (and much more optimized actually)
* added SEGV_PKUERR to copy_siginfo_to_user()
* remove page table walk when filling in si_pkey, added some big fat comments about it being inherently racy.
* added self test code
MM reviewers, if you are going to look at one thing, please look at patch 14 which adds a bunch of additional vma/pte permission checks.
This code contains a new system call: mprotect_key(), This needs the usual amount of rigor around new interfaces. Review there would be much appreciated.
This code is not runnable to anyone outside of Intel unless they have some special hardware or a fancy simulator. If you are interested in running this for real, please get in touch with me. Hardware is available to a very small but nonzero number of people.
This set is also available here (with the new syscall):
git://git.kernel.org/pub/scm/linux/kernel/git/daveh/x86-pkeys.git pkeys-v006
=== diffstat ===
(note that over half of this is kselftests)
Documentation/kernel-parameters.txt | 3 Documentation/x86/protection-keys.txt | 54 + arch/powerpc/include/asm/mman.h | 5 arch/powerpc/include/asm/mmu_context.h | 11 arch/s390/include/asm/mmu_context.h | 11 arch/unicore32/include/asm/mmu_context.h | 11 arch/x86/Kconfig | 15 arch/x86/entry/syscalls/syscall_32.tbl | 1 arch/x86/entry/syscalls/syscall_64.tbl | 1 arch/x86/include/asm/cpufeature.h | 54 + arch/x86/include/asm/disabled-features.h | 12 arch/x86/include/asm/fpu/types.h | 16 arch/x86/include/asm/fpu/xstate.h | 4 arch/x86/include/asm/mmu_context.h | 71 ++ arch/x86/include/asm/pgtable.h | 45 + arch/x86/include/asm/pgtable_types.h | 34 - arch/x86/include/asm/required-features.h | 4 arch/x86/include/asm/special_insns.h | 32 + arch/x86/include/uapi/asm/mman.h | 23 arch/x86/include/uapi/asm/processor-flags.h | 2 arch/x86/kernel/cpu/common.c | 42 + arch/x86/kernel/fpu/xstate.c | 7 arch/x86/kernel/process_64.c | 2 arch/x86/kernel/setup.c | 9 arch/x86/mm/fault.c | 143 +++- arch/x86/mm/gup.c | 37 - drivers/char/agp/frontend.c | 2 drivers/staging/android/ashmem.c | 9 fs/proc/task_mmu.c | 5 include/asm-generic/mm_hooks.h | 11 include/linux/mm.h | 13 include/linux/mman.h | 6 include/uapi/asm-generic/siginfo.h | 17 kernel/signal.c | 4 mm/Kconfig | 11 mm/gup.c | 28 mm/memory.c | 4 mm/mmap.c | 2 mm/mprotect.c | 20 mm/nommu.c | 2 tools/testing/selftests/x86/Makefile | 3 tools/testing/selftests/x86/pkey-helpers.h | 182 +++++ tools/testing/selftests/x86/protection_keys.c | 828 ++++++++++++++++++++++++++ 43 files changed, 1705 insertions(+), 91 deletions(-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>