Fix fdt 'reg' parsing and unbreak few Exynos4 boards
Get series with b4
b4 am 20150930131337.GO22966@bill-the-catVersions newest first
- v3 Latest0 of 4 patches 0 repliesNew
Patches in v3 No applies recorded yet
None of the 4 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [U-Boot] [PATCH V3 0/4] Fix fdt 'reg' parsing and unbreak few Exynos4 boards
Quoted 28 lines · Przemyslaw Marczak
Booting of Odroid U3/X2 with SD card, ends with error:
MMC: EXYNOS DWMMC: 0
Card did not respond to voltage select!
*** Warning - MMC init failed, using default environmentGenerally this was broken, because of wrong addresses, assigned to GPIOs.
The source of the problem was in rework oflib/fdtdec.c, after which functionfdtdec_get_addr()doesn't work as previous and functiondev_get_addr()doesn't works as expected.The code after rework in
lib/fdtdec.cassumed, that #size-cells property, should be always greater or equal to 1, this was wrong, because it can be 0.In case of debugging the issue, I found, that mmc clock was computed wrong, for Exynos4, because of function
get_mmc_clk(), which always returns -1 for this SoC.The patchset should fix booting on all Exynos4 boards, however it was tested
on: Odroid X2 / U3 / XU3 and Trats / Trats2.Przemyslaw Marczak (4):
fdtdec: fix parsing 'reg' property with zero value in '#size-cells'
gpio: s5p: call:dev_get_addr()instead offdtdec_get_addr()
mach-exynos: clock: restore calling deadexynos4_get_mmc_clk()
trats: fdt: disable unused DW MMC
Quoted 5 lines
arch/arm/dts/exynos4210-trats.dts | 4 ++++ arch/arm/mach-exynos/clock.c | 10 ++++------ drivers/gpio/s5p_gpio.c | 18 +++++++++++------- lib/fdtdec.c | 2 +- 4 files changed, 20 insertions(+), 14 deletions(-)
Should I grab this directly or expect a PR from the DT or Samsung tree? Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150930/22ab0067/attachment.sig>