legal-info: save the external-toolchain source archive
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest0 of 4 patches 0 repliesNew
Patches in v2 No applies recorded yet
None of the 4 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [Buildroot] [PATCH v2 0/4] legal-info: save the external-toolchain source archive
Dear Luca Ceresoli,
Quoted 6 lines · Luca Ceresoli
Luca Ceresoli (4):
legal-info: allow to declare the actual sources for binary packages
toolchain-external: mass-define actual source tarball for known
patterns
toolchain-external: define actual sources for arago toolchains docs/manual: document new actual source package variables
All four patches applied, with only the removal of unneeded warning in the first patch.
We noted several things during the review:
* The ifneq ($$($(2)_SITE_METHOD),override) test will always be false because SITE_METHOD is never set to "override". This part of the code should be reworked to simply test $(2)_OVERRIDE_SRCDIR instead:
when empty, it indicates that the packages is neither a "local" site-method package nor a package that has its source directory overridden.
* Maybe the fetching of the "actual source" could be deferred to a separate $(1)-legal-info-source target, to refactor with the existing dependency of $(1)-legal-info on $(1)-source.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com