Misc Intel driver cleanups
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | fm10k: Cleanup MSI-X interrupts in case of failuredrivers/ | +3 | 2 replies | |
| 2/5 | fm10k: Cleanup exception handling for mailbox interruptdrivers/ | +11 | 2 replies | |
| 3/5 | fm10k: Cleanup exception handling for changing queuesdrivers/ drivers/ | +55 | 7 replies | |
| 4/5 | e1000e: Switch e1000e_up to void, drop code checking for error resultdrivers/ drivers/ | +5 | 1 reply | |
| 5/5 | igb: Fix unused variable warningdrivers/ | +0 | 1 reply |
Reviews trailers per patch
3 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Bruce Allan | Krishneil Singh | Aaron Brown |
|---|---|---|---|
| 1/5 | R-b | T-b | |
| 2/5 | R-b | T-b | |
| 3/5 | R-b | T-b | |
| 4/5 | T-b | ||
| 5/5 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Intel-wired-lan] [next PATCH 0/5] Misc Intel driver cleanups
These are some assorted cleanups that occurred to me over the last several days. They are compile tested only.
The first three are based on review of some patches I saw recently accepted into fm10k. We weren't doing consistent exception handling when we probably should have been. Also it looks like there are some exception paths what would have likely resulted in a kernel panic so I decided to try and address those.
The fourth is based on a suggestion I had given to Nick but he ignored. Basically e1000e_up is always returning 0, there was code that was checking for it returning non-zero so I make e1000e_up void and dropped all code that was checking it for a non-zero return value.
The last patch is a minor tweak to an existing patch in the dev-queue. Feel free to just fold it into the patch it fixes and add my signed-off-by or carry it separately. I am good either way.
---
Alexander Duyck (5):
fm10k: Cleanup MSI-X interrupts in case of failure
fm10k: Cleanup exception handling for mailbox interrupt
fm10k: Cleanup exception handling for changing queues
e1000e: Switch e1000e_up to void, drop code checking for error result
igb: Fix unused variable warning
drivers/net/ethernet/intel/e1000e/e1000.h | 2 - drivers/net/ethernet/intel/e1000e/netdev.c | 15 +---- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 4 + drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 17 ++++-- drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 68 ++++++++++++++++++----- drivers/net/ethernet/intel/igb/igb_main.c | 1 6 files changed, 74 insertions(+), 33 deletions(-)
--