(Was: WARNING in task_participate_group_stop)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 patch 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | signal: kill the obsolete SIGNAL_UNKILLABLE check in complete_signal()kernel/ | +1 | 3 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/1] (Was: WARNING in task_participate_group_stop)
Quoted 3 lines · Oleg Nesterov
and I think this should be fixed anyway, if nothing else to make this logic more correct.
Yes, please see the patch.
Quoted 1 line
I'll try to recheck this all later.
I found more problems, will try to send the fixes/cleanups tomorrow...
do_signal_stop() is buggy, a multi-threaded exec can miss SIGSTOP.
task_participate_group_stop() and prepare_signal() are buggy. We must not clear UNKILLABLE when we set STOPPED/CONTINUED.
signal_group_exit() can probably die, it was added before we had fatal_signal_pending().
This reminds that we should finally remove signal_pending() check in fatal_signal_pending(). And change force_sig_info() to take ->ptrace into account.
Oleg.