Skip to content

x86/apic: Implement single target IPI callback

Thomas Gleixner lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14x86/apic: Add a single-target IPI function to the apicarch/x86/include/asm/apic.h arch/x86/kernel/smp.c+15 -20 replies
2/14x86/apic: Implement single target IPI function for x2apic_clusterarch/x86/kernel/apic/x2apic_cluster.c+12 -03 replies
3/14x86/apic: Implement default single target IPI functionarch/x86/include/asm/ipi.h arch/x86/kernel/apic/ipi.c+11 -00 replies
4/14x86/apic: Remove pointless indirections from apic_physflatarch/x86/kernel/apic/apic_flat_64.c+3 -140 replies
5/14x86/apic: Wire up single IPI for apic_physflatarch/x86/kernel/apic/apic_flat_64.c+1 -00 replies
6/14x86/apic: Remove pointless indirections from bigsmp_apicarch/x86/kernel/apic/bigsmp_32.c+2 -70 replies
7/14x86/apic: Wire up single IPI for bigsmp_apicarch/x86/kernel/apic/bigsmp_32.c+1 -00 replies
8/14x86/apic: Implement single IPI for x2apic_physarch/x86/kernel/apic/x2apic_phys.c+12 -00 replies
9/14x86/apic: Wire up single IPI for x2apic_uvarch/x86/kernel/apic/x2apic_uv_x.c+1 -00 replies
10/14x86/apic: Implement single IPI for apic_nooparch/x86/kernel/apic/apic_noop.c+2 -00 replies
11/14x86/apic: Wire up single IPI for apic_numachiparch/x86/kernel/apic/apic_numachip.c+2 -00 replies
12/14x86/apic: Provide default send single IPI wrapperarch/x86/include/asm/ipi.h arch/x86/kernel/apic/ipi.c+9 -00 replies
13/14x86/apic: Use default send single IPI wrapperarch/x86/kernel/apic/apic_flat_64.c arch/x86/kernel/apic/probe_32.c+2 -00 replies
14/14x86/smp: Remove single IPI wrapperarch/x86/kernel/smp.c+2 -140 replies

Reviews trailers per patch

1 of 14 patches has a Reviewed-by or Acked-by.

PatchIngo Molnar
1/14
2/14R-b
3/14
4/14
5/14
6/14
7/14
8/14
9/14
10/14
11/14
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [patch 00/14] x86/apic: Implement single target IPI callback

Linus provided a implementation for this for x2apic_cluster and mumbled at http://marc.info/?l=linux-kernel&m=144660325518209 :

Quoted 10 lines

Side note, I have an *old* patch that I think simplifies the (reasonably common) case of sending IPI's to individual CPU's. That's done by the "reschedule ipi" in particular.

That's something that is trivially done on the x2apic, but that the mask-based interfaces makes insanely complicated.

I have *not* rebased this on top of modern kernels so it may not actually work as a patch any more, because I'm just sending this out as a "Hmm, what do you guys think" rather than a real submission.

I thought it's worthwhile so I had a look at the other apic implementations and all but apic_default and apic_flat can be converted halfways simple to provide a single target callback.

The following series does that and gets rid of the wrapper in the call site at the end.

Compiles and didn't explode when booting it, so it must be perfect :)

Thanks,

tglx

---

 arch/x86/include/asm/apic.h           |    1 +
 arch/x86/include/asm/ipi.h            |    2 ++
 arch/x86/kernel/apic/apic_flat_64.c   |   19 +++++--------------
 arch/x86/kernel/apic/apic_noop.c      |    2 ++
 arch/x86/kernel/apic/apic_numachip.c  |    2 ++
 arch/x86/kernel/apic/bigsmp_32.c      |   10 +++-------
 arch/x86/kernel/apic/ipi.c            |   18 ++++++++++++++++++
 arch/x86/kernel/apic/probe_32.c       |    1 +
 arch/x86/kernel/apic/x2apic_cluster.c |   12 ++++++++++++
 arch/x86/kernel/apic/x2apic_phys.c    |   12 ++++++++++++
 arch/x86/kernel/apic/x2apic_uv_x.c    |    1 +
 arch/x86/kernel/smp.c                 |    4 ++--
 12 files changed, 61 insertions(+), 23 deletions(-)