target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests
Get series with b4
b4 am 20151216060551.10636.77403.stgit@aravindapVersions newest first · linked by author and title
- v2 Latest4 patches 9 repliesIn review
- v14 patches 35 repliesSuperseded
Changes in v2 from the cover letter
- Added KVM capability
- Serialized multiple NMIs with a conditional wait
[1] http://marc.info/?l=kvm&m=145024538523497
[2] https://lists.nongnu.org/archive/html/qemu-devel/2014-11/msg00813.html
[3] https://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00898.html
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | spapr: Register and handle HCALL to receive updated RTAS regionhw/ include/ | +10 | 1 reply | |
| 2/4 | spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS callshw/ include/ | +45 | 2 replies | |
| 3/4 | target-ppc: Handle NMI guest exitcpus.c hw/ include/ +2 more | +186 | 2 replies | |
| 4/4 | spapr: Introduce FWNMI KVM capabilityhw/ linux-headers/ target-ppc/ | +20 | 4 replies |
Reviews trailers per patch
1 of 4 patches has a Reviewed-by or Acked-by.
| Patch | David Gibson |
|---|---|
| 1/4 | R-b |
| 2/4 | |
| 3/4 | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v2 0/4] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests
This series of patches add support for FWNMI in PowerKVM guests.
Memory error such as bit flips that cannot be corrected by hardware is passed on to the kernel for handling by raising machine check exception (an NMI). Upon such machine check exception, if the address in error belongs to guest then KVM causes a guest exit with KVM_EXIT_NMI exit reason [1].
This patch series adds functionality to pass on such machine check exception to the guest kernel by suitably handling KVM_EXIT_NMI exit and building the error log. This patch series explores the alternate design discussed in the QEMU mailing list [2], [3].
In earlier design [2] KVM invoked guest's NMI interrupt vector 0x200 upon machine check exception, while QEMU patched 0x200 vector to issue hcall to facilitate building and copying of error log into RTAS space.
The new design simplifies couple of things. Thanks to David Gibson for the suggestion:
- Eliminates patching of 0x200 interrupt vector from QEMU, hence, trampoline not required
- Avoids introducing a new private hcall to be called from guest's 0x200 vector to enable QEMU to build error log
- Simplifies re-trying by other processors when one of the processor is consuming/processing the error log.
Change Log v2:
- Added KVM capability
- Serialized multiple NMIs with a conditional wait
[1] http://marc.info/?l=kvm&m=145024538523497
[2] https://lists.nongnu.org/archive/html/qemu-devel/2014-11/msg00813.html
[3] https://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00898.html
---
Aravinda Prasad (4):
spapr: Register and handle HCALL to receive updated RTAS region
spapr: Handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls
target-ppc: Handle NMI guest exit
spapr: Introduce FWNMI KVM capability
cpus.c | 5 +++ hw/ppc/spapr.c | 6 +++ hw/ppc/spapr_hcall.c | 8 ++++ hw/ppc/spapr_rtas.c | 53 +++++++++++++++++++++++++++ include/hw/ppc/spapr.h | 13 ++++++- include/qemu/main-loop.h | 8 ++++ linux-headers/linux/kvm.h | 1 + target-ppc/kvm.c | 88 +++++++++++++++++++++++++++++++++++++++++++++ target-ppc/kvm_ppc.h | 81 +++++++++++++++++++++++++++++++++++++++++ 9 files changed, 261 insertions(+), 2 deletions(-)
Signature · 1 line
Aravinda Prasad