Skip to content

stop_machine: stop_one_cpu_nowait() fix, misc cleanups

Oleg Nesterov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8stop_machine: cpu_stopper_thread() must check done != NULLkernel/stop_machine.c+1 -12 replies
2/8stop_machine: don't disable preemption in stop_two_cpus()kernel/stop_machine.c+3 -80 replies
3/8stop_machine: make cpu_stop_queue_work() and stop_one_cpu_nowait() return boolinclude/linux/stop_machine.h kernel/stop_machine.c+13 -52 replies
4/8stop_machine: change stop_one_cpu() to rely on cpu_stop_queue_work()kernel/stop_machine.c+4 -20 replies
5/8stop_machine: change __stop_cpus() to rely on cpu_stop_queue_work()kernel/stop_machine.c+10 -40 replies
6/8stop_machine: kill cpu_stop_done->executedkernel/stop_machine.c+3 -90 replies
7/8stop_machine: shift the done != NULL check from cpu_stop_signal_done() to callerskernel/stop_machine.c+8 -100 replies
8/8stop_machine: cleanup the usage of preemption counter in cpu_stopper_thread()kernel/stop_machine.c+5 -101 reply

Reviews trailers per patch

2 of 8 patches have a Reviewed-by or Acked-by.

PatchTejun Heo
1/8A-b
2/8
3/8
4/8
5/8
6/8
7/8
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] stop_machine: stop_one_cpu_nowait() fix, misc cleanups

Hello,

I tried to backport the recent stop_machine fixes and recalled that I forgot to make the fix and cleanups I promised during the previous discussion.

Please review.

I am also going to rediff/resend my old patch which removes lglock from stop_machine.c, but it probably needs more discussion so I'll send it separately.

Oleg.

 include/linux/stop_machine.h |    2 +-
 kernel/stop_machine.c        |   84 ++++++++++++++++++++---------------------
 2 files changed, 42 insertions(+), 44 deletions(-)