Skip to content

pinctrl: sh-pfc: r8a7794: DU support

Magnus Damm linux-gpio linux-sh lkml 1 version In review

Get series with b4
b4 am 20151117031832.24924.60685.sendpatchset@little-apple

Versions newest first

  1. v1 Latest4 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4pinctrl: sh-pfc: r8a7794: Add DU pin groupsdrivers/pinctrl/sh-pfc/pfc-r8a7794.c+170 -02 replies
2/4pinctrl: sh-pfc: r8a7794: Separate DU CDE and DISPdrivers/pinctrl/sh-pfc/pfc-r8a7794.c+34 -160 replies
3/4pinctrl: sh-pfc: r8a7794: Add missing dot clock signalsdrivers/pinctrl/sh-pfc/pfc-r8a7794.c+26 -81 reply
4/4pinctrl: sh-pfc: r8a7794: Break out ODDF from syncdrivers/pinctrl/sh-pfc/pfc-r8a7794.c+22 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/04] pinctrl: sh-pfc: r8a7794: DU support

pinctrl: sh-pfc: r8a7794: DU support

[PATCH 01/04] pinctrl: sh-pfc: r8a7794: Add DU pin groups [PATCH 02/04] pinctrl: sh-pfc: r8a7794: Separate DU CDE and DISP [PATCH 03/04] pinctrl: sh-pfc: r8a7794: Add missing dot clock signals [PATCH 04/04] pinctrl: sh-pfc: r8a7794: Break out ODDF from sync

These patches take the r8a7794 PFC DU support code from the BSP and reworks it to fit the r8a7794 ALT board. Tested with the ALT VGA port - by default PFC is not used however enabling PFC using an incremental (yet to be posted) patch works well.

It is worth noting that patch 2-4 modifies the pin groups. This means that the upstream DT ABI for PFC DU will differ compared to the unreviewed BSP code.

In general it is not considered good practice to change the pin groups and break compatibility since they are part of the DT ABI.

For this particular case upstream never have had PFC DU support for r8a7794, so treating the BSP bindings as experimental and migrate away seems reasonable.

---

Written against v4.4-rc1

 drivers/pinctrl/sh-pfc/pfc-r8a7794.c |  282 ++++++++++++++++++++++++++++++----
 1 file changed, 252 insertions(+), 30 deletions(-)