usb: s3c-otg: Rename driver to dwc2-otg
Get series with b4
b4 am 20151215154033.3fb7a9c8@amdc2363Versions newest first
- v1 Latest0 of 24 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 24 patches the cover letter announces are in this archive.
Reviews trailers per patch
| Patch | Lukasz Majewski |
|---|---|
| Series | R-b T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [U-Boot] [PATCH 00/24] usb: s3c-otg: Rename driver to dwc2-otg
Hi Marek,
Quoted 168 lines · Marek Vasut
Quoted 167 lines
Quoted 165 lines · Lukasz Majewski
Hi Marek,
Quoted 135 lines
Quoted 133 lines · Lukasz Majewski
Hi Marek,
Quoted 131 lines
On Wednesday, December 09, 2015 at 04:02:58 PM, Lukasz Majewski
Quoted 127 lines · wrote:
Hi Marek,
Quoted 124 lines
On Wednesday, December 09, 2015 at 10:37:42 AM, Lukasz Majewski
Quoted 111 lines · wrote:
Hi Marek,
Quoted 94 lines
The driver is for the dwc2 otg block , so rename it accordingly finally.
Marek Vasut (24):
usb: s3c-otg: Renameregs-otg.htos3c_udc_otg_regs.husb: s3c-otg: Rename structs3c_udctodwc2_udcusb: s3c-otg: Rename structs3c_usbotg_regto
dwc2_usbotg_regusb: s3c-otg: Split private bits froms3c_udc.husb: s3c-otg: Rename structs3c_usbotg_phytodwc2_usbotg_phyusb: s3c-otg:
Rename struct s3c_dev_*_epusb: s3c-otg: Rename struct
s3c_ep
usb: s3c-otg: Rename structs3c_request
usb: s3c-otg: Staticizes3c_udc_ep_set_stall
usb: s3c-otg: Staticize functions in
s3c_udc_otg_xfer_dma.cusb: s3c-otg: Rename s3c_ep0_*() functions usb: s3c-otg: Rename s3c_ep_*() functionsusb: s3c-otg: Rename s3c_udc_*() functions
usb: s3c-otg: Rename remaining local s3c_*()
functions usb: s3c-otg: Zap useless externs
usb: s3c-otg: Change the driver name to dwc2-udc
usb: s3c-otg: Rename local headers to dwc2_*h
usb: s3c-otg: Rename sources to dwc2_*c
usb: s3c-otg: Rename remaining macros
usb: s3c-otg: Tweak the comments
usb: s3c-otg: Rename USB_GADGET_S3C_UDC_OTG* toUSB_GADGET_DWC2_OTG* usb: s3c-otg: Rename struct
s3c_plat_otg_datausb: s3c-otg: Rename
s3c_udc_probe()function
usb: s3c-otg: Renameusb/s3c_udc.htousb/dwc2_udc.h
board/altera/arria5-socdk/socfpga.c
| 6+-
board/altera/cyclone5-socdk/socfpga.c
| 6 +-board/broadcom/bcm28155_ap/bcm28155_ap.c| 8 +-
board/denx/mcvevk/socfpga.c
| 6 +-board/ebv/socrates/socfpga.c
| 6 +-board/samsung/goni/goni.c| 6 +-
board/samsung/odroid/odroid.c
| 6 +-board/samsung/trats/trats.c
| 8 +-board/samsung/trats2/trats2.c| 6 +-
board/samsung/universal_c210/universal.c
| 6 +-board/terasic/sockit/socfpga.c
| 6 +-drivers/usb/gadget/Makefile| 4 +-
drivers/usb/gadget/bcm_udc_otg_phy.c
| 6 +-.../usb/gadget/{s3c_udc_otg.c=>dwc2_udc_otg.c} | 205+++++++++++----------
.../{s3c_udc_otg_phy.c=>dwc2_udc_otg_phy.c} | 21
++-.../usb/gadget/dwc2_udc_otg_priv.h
| 43 ++---.../usb/gadget/{regs-otg.h=>dwc2_udc_otg_regs.h} | 32
++--..._udc_otg_xfer_dma.c=>dwc2_udc_otg_xfer_dma.c} | 202 ++++++++++----------include/configs/bcm28155_ap.h
| 2 +-include/configs/exynos4-common.h
| 4 +-include/configs/s5p_goni.h| 4 +-
include/configs/s5pc210_universal.h
| 4 +-include/configs/smdkv310.h
| 4 +-include/configs/socfpga_common.h| 2 +-
Quoted 14 lines
include/usb/dwc2_udc.h
| 23 +++ 25 files changed, 319 insertions(+), 307 deletions(-) renamedrivers/usb/gadget/{s3c_udc_otg.c=>dwc2_udc_otg.c} (77%) renamedrivers/usb/gadget/{s3c_udc_otg_phy.c=>dwc2_udc_otg_phy.c} (83%) renameinclude/usb/s3c_udc.h=>drivers/usb/gadget/dwc2_udc_otg_priv.h(69%) renamedrivers/usb/gadget/{regs-otg.h=>dwc2_udc_otg_regs.h} (92%) renamedrivers/usb/gadget/{s3c_udc_otg_xfer_dma.c=>dwc2_udc_otg_xfer_dma.c} (88%) create mode 100644include/usb/dwc2_udc.hQuoted 4 lines
What is the base sha1 and branch for those patches?
I cannot apply them on u-boot-usb/master (SHA1:
59a38d86de2439c72d72be54958a04bb1b778410)I should've updated u-boot-usb, sorry about that. I can pick them through u-boot-usb/master if you don't mind to make things easier for you. I put the patches into u-boot-usb/s3c-udc for now.
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Ok, thanks.
I will examine that.
OK, shall I wait with application then ?
Please prepare u-boot-usb/s3c-udc branch.
I've run this patch series through buildman (before running tests):
./tools/buildman/buildman.py--branch=HEAD samsung --detail --verbose --show_errors --force-build --count=24 --output-dir=./BUILD/And I've received several errors:
arm: + odroid
+../board/samsung/odroid/odroid.c:460:15: error: 'PHY0_SLEEP'undeclared here (not in a function)
(quoted diff) +5
-0+ .usb_flags = PHY0_SLEEP, + ^ +make[2]: *** [board/samsung/odroid/odroid.o] Error 1 +make[1]: *** [board/samsung/odroid] Error 2 +make: *** [sub-make] Error 2
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Please fix :-)
Try the attached fix, if it's OK with you I will wrap it into 04/24 .
I pushed the updated branch to u-boot-usb/s3c-udc , so give it a spin.
Test HW: Trats (Exynos4210) and Odroid XU3 (Exynos5800)
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group