Skip to content

bus: sunxi-rsb: fix primary PMIC and peripheral IC address mapping

Olof Johansson linux-arm-kernel 1 version New

Get series with b4
b4 am 20151222194416.GA30172@localhost

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] bus: sunxi-rsb: fix primary PMIC and peripheral IC address mapping
Quoted 14 lines · Chen-Yu Tsai

Hi Arnd, Olof,

Here are 2 fixes for the sunxi-rsb driver. There were some typos in the hardware address mapping table, but as long as the assigned address matched what the bootloader used, it still worked fine. The only indication was "failed to set runtime address" error messages which I mistook for some hardware quirk.

I looked deeper when the AC100 on my A80 boards refused to respond.

Patch 1 fixes the hardware address for primary PMICs (AXP223, AXP809...). This is the part that still worked fine despite the error because the runtime address matches the one set by the bootloader.

Quoted 5 lines

Patch 2 fixes the assigned runtime address for the peripheral IC (AC100/AC200). This part does not work due to the runtime address being invalid.

Maxime asked me to send them directly to you. Please pick them up for 4.4.

Applied, thanks.

In the future, for fixes late in the cycle like this, please describe in a few words in the commit message just what the error is for someone trying to use kernel without the fix, so someone just reading the changelog can determine if it's a high-priority fix or not.

Thanks!

-Olof