RFC all: use 'menuconfig' to group sub-options (branch yem/menuconfig)
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest0 of 84 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 84 patches the cover letter announces are in this archive.
Reviews trailers per patch
| Patch | Arnout Vandecappelle (Essensium/Mind) |
|---|---|
| Series | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig)
Arnout, All,
On 2016-01-02 02:47 +0100, Arnout Vandecappelle spake thusly:
Quoted 22 lines · Yann E. MORIN
Quoted 21 lines
On 2015-12-31 01:23 +0100, Arnout Vandecappelle spake thusly:
Quoted 20 lines · Yann E. MORIN
Quoted 18 lines
Hello All!
This RFC series is a proposal to cleanup the layout of the menuconfig UI. Although it looks to be pretty long (84 patches), it really is only three different changes :
- patches 1-6: re-order comments to fix indentation of sub-options; this can probably be applied without too much discussion, as it is really only a cleanup;
- patches 7-35: changes use of 'config'+'menu' into a 'menuconfig' (the
Kconfigkeywords) to automatically arrange the sub-options into sub-menus;- patches 36-84: document that packages with 5 or more options should use sub-menus (with 'menuconfig') to store their sub-options (patches 36-39); it then changes a lot of packages accordingly (patches 40-84).
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
I reviewed and tested patches 7-39, you can add my
Thank you for the review. I know by experience that reviewing long series can be tedious, so: thanks!
You can now ack up to and including 58 (libiio).
Great! Thank you very much for having had another look! :-)
(I'll add your ACKs after fixing the little nits here and there you already commented on, like comments to drop...)
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines
to the ones where I didn't have comments. I didn't bother adding Acks everywhere because it's anyway not going to be picked up by Patchwork.
Yep, I sent the series as an RFC, just to "feel the temperature of the water".
For actual submission, perhaps squash a little here and there. Although in fact
they're not really squashable, except perhaps 41-84 but that would be a pretty big patch.
Well, and what about my commit count? ;-]
But yeah, I don't think we could squash it, at least during the review. I think it is easier to review a lot of little patches rather than a bit one even if the changes are simple.
Thanks!
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'