Skip to content

staging/rdma/hfi1: Various bug fixes for hfi1 post rdmavt

Dennis Dalessandro linux-rdma 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest54 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/54staging/rdma/hfi1: Remove srq functionalitydrivers/staging/rdma/hfi1/Makefile drivers/staging/rdma/hfi1/srq.c drivers/staging/rdma/hfi1/verbs.c +1 more+1 -4210 replies
2/54staging/rdma/hfi1: HFI reports wrong offline disabled reason when cable removeddrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/hfi.h drivers/staging/rdma/hfi1/intr.c +1 more+34 -130 replies
3/54staging/rdma/hfi1: cleanup messages on qsfp_read() failuredrivers/staging/rdma/hfi1/qsfp.c+8 -80 replies
4/54staging/rdma/hfi1: Fix QSFP memory read/write across 128 byte boundarydrivers/staging/rdma/hfi1/qsfp.c drivers/staging/rdma/hfi1/qsfp.h+49 -230 replies
5/54staging/rdma/hfi1: Add active and optical cable supportdrivers/staging/rdma/hfi1/Makefile drivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/chip.h +5 more+1032 -1740 replies
6/54staging/rdma/hfi1: Get port type from configuration filedrivers/staging/rdma/hfi1/mad.c drivers/staging/rdma/hfi1/opa_compat.h+1 -260 replies
7/54staging/rdma/hfi1: Support external device configuration requests from 8051drivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/chip.h drivers/staging/rdma/hfi1/hfi.h +1 more+49 -60 replies
8/54staging/rdma/hfi1: Fix missing firmware NULL dereferencedrivers/staging/rdma/hfi1/firmware.c drivers/staging/rdma/hfi1/pcie.c+15 -120 replies
9/54staging/rdma/hfi1: Fix per-VL transmit discard countsdrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/hfi.h drivers/staging/rdma/hfi1/sdma.c +1 more+123 -260 replies
10/54staging/rdma/hfi1: Only warn when board description is not founddrivers/staging/rdma/hfi1/chip.c+1 -10 replies
11/54staging/rdma/hfi1: Make firmware failure messages warningsdrivers/staging/rdma/hfi1/firmware.c+10 -80 replies
12/54staging/rdma/hfi1: Don't attempt to qualify or tune loopback plugsdrivers/staging/rdma/hfi1/platform.c+2 -10 replies
13/54staging/rdma/hfi1: No firmware retry for simulationdrivers/staging/rdma/hfi1/firmware.c+2 -10 replies
14/54staging/rdma/hfi1: Skip lcb init for simulationdrivers/staging/rdma/hfi1/chip.c+4 -00 replies
15/54staging/rdma/hfi1: Fix for 32-bit counter overflow in driver and hfi1statsdrivers/staging/rdma/hfi1/chip.c+73 -250 replies
16/54staging/rdma/hfi1: Correctly set RcvCtxtCtrl registerdrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/file_ops.c drivers/staging/rdma/hfi1/init.c+24 -50 replies
17/54staging/rdma/hfi1: Method to toggle "fast ECN" detectionDocumentation/infiniband/sysfs.txt drivers/staging/rdma/hfi1/Kconfig drivers/staging/rdma/hfi1/driver.c +2 more+77 -280 replies
18/54staging/rdma/hfi1: Add support for enabling/disabling PCIe ASPMdrivers/staging/rdma/hfi1/aspm.h drivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/chip_registers.h +4 more+355 -73 replies
19/54staging/rdma/hfi1: Fix SL->SC checksdrivers/staging/rdma/hfi1/qp.c drivers/staging/rdma/hfi1/verbs.c drivers/staging/rdma/hfi1/verbs.h+23 -00 replies
20/54staging/rdma/hfi1: Remove unused codedrivers/staging/rdma/hfi1/init.c+0 -70 replies
21/54staging/rdma/hfi1: Remove unnecessary duplicated variabledrivers/staging/rdma/hfi1/hfi.h drivers/staging/rdma/hfi1/init.c drivers/staging/rdma/hfi1/qp.h +1 more+2 -80 replies
22/54staging/rdma/hfi1: Consolidate CPU/IRQ affinity supportdrivers/staging/rdma/hfi1/Makefile drivers/staging/rdma/hfi1/affinity.c drivers/staging/rdma/hfi1/affinity.h +4 more+578 -1130 replies
23/54staging/rdma/hfi1: Allocate send ctxt on device NUMA nodedrivers/staging/rdma/hfi1/file_ops.c+1 -10 replies
24/54staging/rdma/hfi1: Verbs Mem affinity supportdrivers/staging/rdma/hfi1/init.c drivers/staging/rdma/hfi1/qp.c+5 -30 replies
25/54staging/rdma/hfi1: Change send_schedule counter to a per cpu counterdrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/hfi.h drivers/staging/rdma/hfi1/init.c +2 more+15 -40 replies
26/54staging/rdma/hfi1: Fix for generic I2C interfacedrivers/staging/rdma/hfi1/debugfs.c drivers/staging/rdma/hfi1/qsfp.c drivers/staging/rdma/hfi1/qsfp.h +1 more+122 -1100 replies
27/54staging/rdma/hfi1: Allow a fair scheduling of QPsdrivers/staging/rdma/hfi1/ruc.c+38 -140 replies
28/54staging/rdma/hfi1: Fix for module parameter rcvhdrcnt when it's 2097152drivers/staging/rdma/hfi1/init.c+8 -00 replies
29/54staging/rdma/hfi1: Improve performance of TID cache look updrivers/staging/rdma/hfi1/hfi.h drivers/staging/rdma/hfi1/user_exp_rcv.c+83 -720 replies
30/54staging/rdma/hfi1: Reduce syslog message severity and provide speed informationdrivers/staging/rdma/hfi1/pcie.c+1 -30 replies
31/54staging/rdma/hfi1: Use device file minor to identify EPROMdrivers/staging/rdma/hfi1/eprom.c drivers/staging/rdma/hfi1/eprom.h drivers/staging/rdma/hfi1/file_ops.c+12 -70 replies
32/54staging/rdma/hfi1: Improve performance of SDMA transfersdrivers/staging/rdma/hfi1/user_sdma.c drivers/staging/rdma/hfi1/user_sdma.h+128 -1680 replies
33/54staging/rdma/hfi1: correctly check for post-interrupt packetsdrivers/staging/rdma/hfi1/chip.c+25 -70 replies
34/54staging/rdma/hfi1: Properly determine error status of SDMA slotsdrivers/staging/rdma/hfi1/sdma.c drivers/staging/rdma/hfi1/user_sdma.c+14 -70 replies
35/54staging/rdma/hfi1: Report physical state changes per device instead of globallydrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/hfi.h+4 -30 replies
36/54staging/rdma/hfi1: Fix fabric serdes reset by re-downloading firmwaredrivers/staging/rdma/hfi1/firmware.c+44 -130 replies
37/54staging/rdma/hfi1: Split last 8 bytes of copy to user bufferdrivers/staging/rdma/hfi1/rc.c drivers/staging/rdma/hfi1/ruc.c drivers/staging/rdma/hfi1/uc.c +3 more+57 -200 replies
38/54staging/rdma/hfi1: Implement LED beaconing for maintenancedrivers/staging/rdma/hfi1/driver.c drivers/staging/rdma/hfi1/hfi.h drivers/staging/rdma/hfi1/init.c +1 more+64 -610 replies
39/54staging/rdma/hfi1: Remove PCIe AER diagnostic messagedrivers/staging/rdma/hfi1/pcie.c+1 -70 replies
40/54staging/rdma/hfi1: Correct TWSI resetdrivers/staging/rdma/hfi1/qsfp.c drivers/staging/rdma/hfi1/twsi.c drivers/staging/rdma/hfi1/twsi.h+36 -450 replies
41/54staging/rdma/hfi1: Fix snoop packet length calculationdrivers/staging/rdma/hfi1/diag.c+4 -50 replies
42/54staging/rdma/hfi1: Clean up init_cntrs()drivers/staging/rdma/hfi1/chip.c+0 -180 replies
43/54staging/rdma/hfi1: Support query gid in rdmavtdrivers/staging/rdma/hfi1/verbs.c+12 -200 replies
44/54staging/rdma/hfi1: Remove modify_port and port_immutable functionsdrivers/staging/rdma/hfi1/hfi.h drivers/staging/rdma/hfi1/mad.c drivers/staging/rdma/hfi1/verbs.c +1 more+28 -550 replies
45/54staging/rdma/hfi1, IB/core: Fix LinkDownReason define for consistencydrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/platform.c include/rdma/opa_port_info.h+4 -40 replies
46/54staging/rdma/hfi1: Improve performance of user SDMAdrivers/staging/rdma/hfi1/user_sdma.c drivers/staging/rdma/hfi1/user_sdma.h+22 -400 replies
47/54staging/rdma/hfi1: Add credits for VL0 to VL7 in snoop modedrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/diag.c drivers/staging/rdma/hfi1/hfi.h+66 -20 replies
48/54staging/rdma/hfi1: Make EPROM check per devicedrivers/staging/rdma/hfi1/eprom.c drivers/staging/rdma/hfi1/hfi.h+6 -110 replies
49/54staging/rdma/hfi1: Remove unused variable nsbrdrivers/staging/rdma/hfi1/pcie.c+0 -70 replies
50/54staging/rdma/hfi1: Fix bug that could block the process on context exitdrivers/staging/rdma/hfi1/user_sdma.c+4 -10 replies
51/54staging/rdma/hfi1: Change for data type of port numberdrivers/staging/rdma/hfi1/mad.c+7 -70 replies
52/54staging/rdma/hfi1: Replacement of goto's for break/returnsdrivers/staging/rdma/hfi1/mad.c+30 -260 replies
53/54staging/rdma/hfi1: Adding support for hfi counters via sysfsdrivers/staging/rdma/hfi1/mad.c+252 -540 replies
54/54staging/rdma/hfi1: Removing unused struct hfi1_verbs_countersdrivers/staging/rdma/hfi1/verbs.h+0 -160 replies

Reviews trailers per patch

53 of 54 patches have a Reviewed-by or Acked-by.

PatchDennis DalessandroHarish ChegondiMike MarciniszynEaswar HariharanDean LuickIra WeinyBrent R RothermelArthur KepnerMitko HaralanovStuart Summers
1/54R-b R-b
2/54R-b R-b R-b
3/54R-b
4/54R-b R-b
5/54R-b R-b R-b
6/54R-b
7/54R-b
8/54R-b
9/54R-b R-b
10/54R-b
11/54R-b
12/54R-b
13/54R-b
14/54R-b
15/54R-b
16/54R-b
17/54R-b R-b
18/54R-b R-b R-b
19/54R-b R-b
20/54R-b
21/54R-b
22/54R-b R-b R-b
23/54R-b R-b R-b
24/54R-b R-b
25/54R-b
26/54R-b R-b
27/54R-b
28/54R-b R-b
29/54R-b R-b
30/54R-b
31/54R-b
32/54R-b R-b
33/54R-b
34/54R-b
35/54R-b
36/54R-b
37/54R-b
38/54R-b
39/54R-b
40/54R-b R-b
41/54R-b
42/54R-b R-b
43/54R-b
44/54
45/54R-b
46/54R-b
47/54R-b R-b
48/54R-b
49/54R-b
50/54R-b
51/54R-b
52/54R-b
53/54R-b
54/54R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 10 reviewers.

Read the v1 thread

Cover letter [PATCH 00/54] staging/rdma/hfi1: Various bug fixes for hfi1 post rdmavt

This is a pretty big patch series. It brings in a large number of fixes that we have been holding onto due to conflicts with rdmavt and the two maintainer model we were previously operating under.

This applies on top of the previously posted "Finish adding core rdmavt verbs support" patch and can be seen in context at:
https://github.com/ddalessa/kernel/tree/for-4.6

---

Ashutosh Dixit (1):
staging/rdma/hfi1: Add support for enabling/disabling PCIe ASPM

Bryan Morgan (1):
staging/rdma/hfi1: HFI reports wrong offline disabled reason when cable removed

Dean Luick (16):
staging/rdma/hfi1: Fix missing firmware NULL dereference staging/rdma/hfi1: Only warn when board description is not found staging/rdma/hfi1: Make firmware failure messages warnings staging/rdma/hfi1: No firmware retry for simulation staging/rdma/hfi1: Skip lcb init for simulation staging/rdma/hfi1: Fix for generic I2C interface staging/rdma/hfi1: Use device file minor to identify EPROM staging/rdma/hfi1: correctly check for post-interrupt packets staging/rdma/hfi1: Report physical state changes per device instead of globally staging/rdma/hfi1: Fix fabric serdes reset by re-downloading firmware staging/rdma/hfi1: Split last 8 bytes of copy to user buffer staging/rdma/hfi1: Remove PCIe AER diagnostic message staging/rdma/hfi1: Correct TWSI reset
staging/rdma/hfi1: Fix snoop packet length calculation staging/rdma/hfi1: Make EPROM check per device
staging/rdma/hfi1: Remove unused variable nsbr

Dennis Dalessandro (1):
staging/rdma/hfi1: Support query gid in rdmavt

Easwar Hariharan (8):
staging/rdma/hfi1: cleanup messages on qsfp_read() failure staging/rdma/hfi1: Add active and optical cable support staging/rdma/hfi1: Get port type from configuration file staging/rdma/hfi1: Support external device configuration requests from 8051 staging/rdma/hfi1: Don't attempt to qualify or tune loopback plugs staging/rdma/hfi1: Reduce syslog message severity and provide speed information staging/rdma/hfi1: Implement LED beaconing for maintenance staging/rdma/hfi1,IB/core: Fix LinkDownReason define for consistency

Harish Chegondi (1):
staging/rdma/hfi1: Remove modify_port and port_immutable functions

Ira Weiny (1):

      staging/rdma/hfi1: Fix SL->SC checks

Jubin John (2):
staging/rdma/hfi1: Remove srq functionality
staging/rdma/hfi1: Clean up init_cntrs()

Mike Marciniszyn (2):
staging/rdma/hfi1: Fix QSFP memory read/write across 128 byte boundary staging/rdma/hfi1: Fix per-VL transmit discard counts

Mitko Haralanov (11):
staging/rdma/hfi1: Correctly set RcvCtxtCtrl register staging/rdma/hfi1: Remove unused code
staging/rdma/hfi1: Remove unnecessary duplicated variable staging/rdma/hfi1: Consolidate CPU/IRQ affinity support staging/rdma/hfi1: Allocate send ctxt on device NUMA node staging/rdma/hfi1: Verbs Mem affinity support staging/rdma/hfi1: Improve performance of TID cache look up staging/rdma/hfi1: Improve performance of SDMA transfers staging/rdma/hfi1: Properly determine error status of SDMA slots staging/rdma/hfi1: Improve performance of user SDMA staging/rdma/hfi1: Fix bug that could block the process on context exit

Sadanand Warrier (1):
staging/rdma/hfi1: Add credits for VL0 to VL7 in snoop mode

Sebastian Sanchez (6):
staging/rdma/hfi1: Fix for 32-bit counter overflow in driver and hfi1stats staging/rdma/hfi1: Fix for module parameter rcvhdrcnt when it's 2097152 staging/rdma/hfi1: Change for data type of port number staging/rdma/hfi1: Replacement of goto's for break/returns staging/rdma/hfi1: Adding support for hfi counters via sysfs staging/rdma/hfi1: Removing unused struct hfi1_verbs_counters

Vennila Megavannan (3):
staging/rdma/hfi1: Method to toggle "fast ECN" detection staging/rdma/hfi1: Change send_schedule counter to a per cpu counter staging/rdma/hfi1: Allow a fair scheduling of QPs

 Documentation/infiniband/sysfs.txt          |    3 
 drivers/staging/rdma/hfi1/Kconfig           |   10 
 drivers/staging/rdma/hfi1/Makefile          |    7 
 drivers/staging/rdma/hfi1/affinity.c        |  433 ++++++++++++++
 drivers/staging/rdma/hfi1/affinity.h        |   94 +++
 drivers/staging/rdma/hfi1/aspm.h            |  297 ++++++++++
 drivers/staging/rdma/hfi1/chip.c            |  803 +++++++++++++++-----------
 drivers/staging/rdma/hfi1/chip.h            |    9 
 drivers/staging/rdma/hfi1/chip_registers.h  |    3 
 drivers/staging/rdma/hfi1/debugfs.c         |    6 
 drivers/staging/rdma/hfi1/diag.c            |   73 ++
 drivers/staging/rdma/hfi1/driver.c          |  105 ++-
 drivers/staging/rdma/hfi1/eprom.c           |   31 -
 drivers/staging/rdma/hfi1/eprom.h           |    2 
 drivers/staging/rdma/hfi1/file_ops.c        |   51 +-
 drivers/staging/rdma/hfi1/firmware.c        |  100 ++-
 drivers/staging/rdma/hfi1/hfi.h             |   93 ++-
 drivers/staging/rdma/hfi1/init.c            |   69 +-
 drivers/staging/rdma/hfi1/intr.c            |    3 
 drivers/staging/rdma/hfi1/mad.c             |  426 ++++++++++----
 drivers/staging/rdma/hfi1/opa_compat.h      |   15 
 drivers/staging/rdma/hfi1/pcie.c            |   40 +
 drivers/staging/rdma/hfi1/platform.c        |  839 +++++++++++++++++++++++++++
 drivers/staging/rdma/hfi1/platform.h        |   44 +
 drivers/staging/rdma/hfi1/qp.c              |   25 +
 drivers/staging/rdma/hfi1/qp.h              |    2 
 drivers/staging/rdma/hfi1/qsfp.c            |  152 +++--
 drivers/staging/rdma/hfi1/qsfp.h            |   35 +
 drivers/staging/rdma/hfi1/rc.c              |   17 -
 drivers/staging/rdma/hfi1/ruc.c             |   62 +-
 drivers/staging/rdma/hfi1/sdma.c            |   12 
 drivers/staging/rdma/hfi1/sdma.h            |    2 
 drivers/staging/rdma/hfi1/srq.c             |  397 -------------
 drivers/staging/rdma/hfi1/sysfs.c           |   66 ++
 drivers/staging/rdma/hfi1/twsi.c            |  198 +++---
 drivers/staging/rdma/hfi1/twsi.h            |    7 
 drivers/staging/rdma/hfi1/uc.c              |   10 
 drivers/staging/rdma/hfi1/ud.c              |    9 
 drivers/staging/rdma/hfi1/user_exp_rcv.c    |  149 +++--
 drivers/staging/rdma/hfi1/user_sdma.c       |  304 ++++------
 drivers/staging/rdma/hfi1/user_sdma.h       |    6 
 drivers/staging/rdma/hfi1/verbs.c           |  143 ++---
 drivers/staging/rdma/hfi1/verbs.h           |   40 -
 include/rdma/opa_port_info.h                |    2 
 44 files changed, 3513 insertions(+), 1681 deletions(-)
 create mode 100644 drivers/staging/rdma/hfi1/affinity.c
 create mode 100644 drivers/staging/rdma/hfi1/affinity.h
 create mode 100644 drivers/staging/rdma/hfi1/aspm.h
 create mode 100644 drivers/staging/rdma/hfi1/platform.c
 rename drivers/staging/rdma/hfi1/{platform_config.h => platform.h} (91%)
 delete mode 100644 drivers/staging/rdma/hfi1/srq.c
Signature · 5 lines
-Denny
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Read the cover letter in its thread