Skip to content

xen: sched: Credit1 shouldn't boost vcpus being migrated.

Dario Faggioli xen-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] xen: sched: Credit1 shouldn't boost vcpus being migrated.

Hi again,

Here it comes v2, redone following Jan's suggestion, which allowed to get rid of patch 2, and do everything in sched_credit.c.

So, in summary, because of the fact that vcpu_migrate() forces the vcpus into a sleep+wakeup cycle, vcpus being migrated to a new pcpu, were also being granted BOOST priority, inside Credit1, and that is not correct.

More info on v1's cover letter, which is here:

http://lists.xenproject.org/archives/html/xen-devel/2016-02/msg01620.html

I re-run the same set of benchmarks described in v1, and the result for this rework of the series are basically the same as there.

Thanks and Regards,
Dario
---
Dario Faggioli (2):
xen: credit1: trace vCPU boost/unboost
xen: credit1: avoid boosting vCPUs being "just" migrated

 xen/common/sched_credit.c    |   34 ++++++++++++++++++++++++++++++----
 xen/include/xen/perfc_defn.h |    1 +
 2 files changed, 31 insertions(+), 4 deletions(-)

--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-------------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)