Skip to content

IB/rdamvt, qib, hfi1: Code cleanups, bug fixes, and perf improvements

Dennis Dalessandro linux-rdma 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12IB/qib: Rename several functions by adding a "qib_" prefixdrivers/infiniband/hw/qib/qib.h drivers/infiniband/hw/qib/qib_qp.c drivers/infiniband/hw/qib/qib_verbs.c +1 more+39 -390 replies
2/12IB/qib, staging/rdma/hfi1: add s_hlock for use in post senddrivers/infiniband/hw/qib/qib_qp.c drivers/infiniband/hw/qib/qib_rc.c drivers/infiniband/hw/qib/qib_ruc.c +15 more+319 -2210 replies
3/12IB/rdmavt: Add trace and error print statements in post_one_wrdrivers/infiniband/sw/rdmavt/qp.c drivers/infiniband/sw/rdmavt/trace.h+77 -10 replies
4/12staging/rdma/hfi1: Put QPs into error state after SL->SC table changesdrivers/staging/rdma/hfi1/mad.c drivers/staging/rdma/hfi1/qp.c drivers/staging/rdma/hfi1/qp.h+64 -20 replies
5/12IB/rdmavt: Clean up comments and add more documentationdrivers/infiniband/sw/rdmavt/ah.c drivers/infiniband/sw/rdmavt/cq.c drivers/infiniband/sw/rdmavt/mad.c +8 more+280 -780 replies
6/12IB/rdmavt: Add per verb driver callback checkingdrivers/infiniband/sw/rdmavt/vt.c include/rdma/rdma_vt.h+489 -750 replies
7/12IB/qib: Setup notify free/create mad agent callbacks for rdmavtdrivers/infiniband/hw/qib/qib_verbs.c+4 -00 replies
8/12IB/qib,rdmavt: Move smi_ah to qibdrivers/infiniband/hw/qib/qib_iba7322.c drivers/infiniband/hw/qib/qib_verbs.h include/rdma/rdma_vt.h+6 -60 replies
9/12IB/rdmavt: Remove RVT_FLAGsdrivers/infiniband/sw/rdmavt/cq.c drivers/infiniband/sw/rdmavt/mr.c drivers/infiniband/sw/rdmavt/qp.c +1 more+0 -280 replies
10/12IB/rdmavt: Remove signal_supported and commentsinclude/rdma/rdma_vt.h+0 -180 replies
11/12IB/rdmavt: Remove unnecessary exported functionsdrivers/infiniband/sw/rdmavt/mmap.c drivers/infiniband/sw/rdmavt/mmap.h drivers/infiniband/sw/rdmavt/qp.c +4 more+128 -1550 replies
12/12IB/qib: Destroy SMI AH before de-allocating the protection domaindrivers/infiniband/hw/qib/qib_iba7322.c drivers/infiniband/hw/qib/qib_mad.c+3 -20 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchMike MarciniszynDennis DalessandroJubin JohnIra Weiny
1/12R-b R-b
2/12R-b R-b
3/12R-b
4/12R-b R-b
5/12R-b
6/12R-b
7/12R-b R-b
8/12R-b R-b
9/12R-b R-b
10/12R-b R-b
11/12R-b
12/12R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/12] IB/rdamvt, qib, hfi1: Code cleanups, bug fixes, and perf improvements

This series adds in mostly code clean ups. The driver provided functions are documented and checked based on which verbs drivers are expecting rdmavt to provide. There are also a couple of bug fixes included in this series, along with a performance improvement patch which adds a dual lock to the sending side.

The patches here apply on the previously submitted "Misc bug fixes for hfi1" and can be seen in context at: https://github.com/ddalessa/kernel/tree/for-4.6.

---

Dennis Dalessandro (7):
IB/rdmavt: Clean up comments and add more documentation IB/rdmavt: Add per verb driver callback checking IB/qib: Setup notify free/create mad agent callbacks for rdmavt IB/qib,rdmavt: Move smi_ah to qib
IB/rdmavt: Remove RVT_FLAGs
IB/rdmavt: Remove signal_supported and comments IB/rdmavt: Remove unnecessary exported functions

Harish Chegondi (3):
IB/qib: Rename several functions by adding a "qib_" prefix IB/rdmavt: Add trace and error print statements in post_one_wr IB/qib: Destroy SMI AH before de-allocating the protection domain

Kaike Wan (1):

      staging/rdma/hfi1: Put QPs into error state after SL->SC table changes

Mike Marciniszyn (1):
IB/qib,staging/rdma/hfi1: add s_hlock for use in post send

 drivers/infiniband/hw/qib/qib.h         |   16 -
 drivers/infiniband/hw/qib/qib_iba7322.c |    8 
 drivers/infiniband/hw/qib/qib_mad.c     |    3 
 drivers/infiniband/hw/qib/qib_qp.c      |   62 +++-
 drivers/infiniband/hw/qib/qib_rc.c      |   44 +--
 drivers/infiniband/hw/qib/qib_ruc.c     |   11 -
 drivers/infiniband/hw/qib/qib_uc.c      |   22 +
 drivers/infiniband/hw/qib/qib_ud.c      |   22 +
 drivers/infiniband/hw/qib/qib_verbs.c   |   67 +++-
 drivers/infiniband/hw/qib/qib_verbs.h   |   17 +
 drivers/infiniband/sw/rdmavt/ah.c       |   27 ++
 drivers/infiniband/sw/rdmavt/cq.c       |   35 +-
 drivers/infiniband/sw/rdmavt/mad.c      |   30 +-
 drivers/infiniband/sw/rdmavt/mcast.c    |   34 ++
 drivers/infiniband/sw/rdmavt/mmap.c     |   32 +-
 drivers/infiniband/sw/rdmavt/mmap.h     |    8 
 drivers/infiniband/sw/rdmavt/mr.c       |   43 ++-
 drivers/infiniband/sw/rdmavt/pd.c       |   16 +
 drivers/infiniband/sw/rdmavt/qp.c       |  382 ++++++++++++++----------
 drivers/infiniband/sw/rdmavt/srq.c      |   22 +
 drivers/infiniband/sw/rdmavt/trace.h    |   70 ++++
 drivers/infiniband/sw/rdmavt/vt.c       |  503 ++++++++++++++++++++++++++-----
 drivers/infiniband/sw/rdmavt/vt.h       |    1 
 drivers/staging/rdma/hfi1/mad.c         |   13 +
 drivers/staging/rdma/hfi1/qp.c          |  131 ++++++++
 drivers/staging/rdma/hfi1/qp.h          |   38 --
 drivers/staging/rdma/hfi1/rc.c          |   44 +--
 drivers/staging/rdma/hfi1/ruc.c         |   40 +-
 drivers/staging/rdma/hfi1/uc.c          |   21 +
 drivers/staging/rdma/hfi1/ud.c          |   22 +
 drivers/staging/rdma/hfi1/verbs.c       |    3 
 drivers/staging/rdma/hfi1/verbs.h       |    2 
 include/rdma/rdma_vt.h                  |  184 +++++++----
 include/rdma/rdmavt_qp.h                |   17 +
 34 files changed, 1387 insertions(+), 603 deletions(-)
Signature · 5 lines
-Denny
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html