Skip to content

staging/rdma/hfi1: finish checkpatch fixes

Dennis Dalessandro linux-rdma 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest21 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21staging/rdma/hfi1: Add spaces around binary operatorsdrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/debugfs.c drivers/staging/rdma/hfi1/driver.c +16 more+115 -1150 replies
2/21staging/rdma/hfi1: Remove multiple blank linesdrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/debugfs.c drivers/staging/rdma/hfi1/file_ops.c +15 more+0 -410 replies
3/21staging/rdma/hfi1: Remove space after castdrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/debugfs.c drivers/staging/rdma/hfi1/dma.c +12 more+64 -640 replies
4/21staging/rdma/hfi1: Fix comparison to NULLdrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/debugfs.c drivers/staging/rdma/hfi1/driver.c +6 more+19 -190 replies
5/21staging/rdma/hfi1: Remove blank line after an open bracedrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/driver.c drivers/staging/rdma/hfi1/mad.c +3 more+0 -150 replies
6/21staging/rdma/hfi1: Remove blank line before close bracedrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/driver.c drivers/staging/rdma/hfi1/intr.c +6 more+0 -120 replies
7/21staging/rdma/hfi1: Fix logical continuationsdrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/driver.c drivers/staging/rdma/hfi1/file_ops.c +4 more+51 -610 replies
8/21staging/rdma/hfi1: Add blank link after declarationsdrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/debugfs.c drivers/staging/rdma/hfi1/firmware.c +3 more+8 -00 replies
9/21staging/rdma/hfi1: Remove unnecessary parenthesesdrivers/staging/rdma/hfi1/mad.c+7 -70 replies
10/21staging/rdma/hfi1: Use BIT_ULL macrodrivers/staging/rdma/hfi1/chip.h drivers/staging/rdma/hfi1/eprom.c drivers/staging/rdma/hfi1/sdma.h+13 -130 replies
11/21staging/rdma/hfi1: Split multiple assignmentsdrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/mad.c drivers/staging/rdma/hfi1/sdma.h+10 -70 replies
12/21staging/rdma/hfi1: Fix misspellingsdrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/qsfp.c drivers/staging/rdma/hfi1/sdma.c+3 -30 replies
13/21staging/rdma/hfi1: Remove CamelCasedrivers/staging/rdma/hfi1/chip.h+1 -10 replies
14/21staging/rdma/hfi1: Use pointer instead of struct namedrivers/staging/rdma/hfi1/pio.c+1 -10 replies
15/21staging/rdma/hfi1: Remove void function return statementdrivers/staging/rdma/hfi1/uc.c+0 -10 replies
16/21staging/rdma/hfi1: Add comment for spinlock_t definitiondrivers/staging/rdma/hfi1/hfi.h drivers/staging/rdma/hfi1/qsfp.h drivers/staging/rdma/hfi1/sdma.h+5 -00 replies
17/21staging/rdma/hfi1: Fix block commentsdrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/chip.h drivers/staging/rdma/hfi1/file_ops.c +11 more+203 -1070 replies
18/21staging/rdma/hfi1: Fix code alignmentdrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/debugfs.c drivers/staging/rdma/hfi1/driver.c +23 more+1508 -15970 replies
19/21staging/rdma/hfi1: Add braces on all arms of statementdrivers/staging/rdma/hfi1/chip.c drivers/staging/rdma/hfi1/driver.c drivers/staging/rdma/hfi1/file_ops.c +11 more+100 -780 replies
20/21staging/rdma/hfi1: Remove else after breakdrivers/staging/rdma/hfi1/qp.c+2 -40 replies
21/21staging/rdma/hfi1: Fix headerdrivers/staging/rdma/hfi1/affinity.c drivers/staging/rdma/hfi1/affinity.h drivers/staging/rdma/hfi1/aspm.h +52 more+55 -2200 replies

Reviews trailers per patch

All 21 patches have a Reviewed-by or Acked-by.

PatchDennis DalessandroIra WeinyMike Marciniszyn
1/21R-b R-b R-b
2/21R-b R-b R-b
3/21R-b R-b R-b
4/21R-b R-b R-b
5/21R-b R-b R-b
6/21R-b R-b R-b
7/21R-b R-b R-b
8/21R-b R-b R-b
9/21R-b R-b R-b
10/21R-b R-b R-b
11/21R-b R-b R-b
12/21R-b R-b R-b
13/21R-b R-b R-b
14/21R-b R-b R-b
15/21R-b R-b R-b
16/21R-b R-b R-b
17/21R-b R-b R-b
18/21R-b R-b R-b
19/21R-b R-b R-b
20/21R-b R-b R-b
21/21R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/21] staging/rdma/hfi1: finish checkpatch fixes

This series adds the remaining checkpatch fixes for the hfi1 driver. This was done with strict. Any remaining checkpatch issues are intentionally left and should not be changed. A lot of the checkpatch issues were cleaned up as the code moved to rdmavt, this is the remainder.

Applies on the "Adaptive PIO performance improvement" series and can be seen in context at https://github.com/ddalessa/kernel/tree/for-4.6.

---

Jubin John (21):
staging/rdma/hfi1: Add spaces around binary operators staging/rdma/hfi1: Remove multiple blank lines staging/rdma/hfi1: Remove space after cast staging/rdma/hfi1: Fix comparison to NULL staging/rdma/hfi1: Remove blank line after an open brace staging/rdma/hfi1: Remove blank line before close brace staging/rdma/hfi1: Fix logical continuations staging/rdma/hfi1: Add blank link after declarations staging/rdma/hfi1: Remove unnecessary parentheses staging/rdma/hfi1: Use BIT_ULL macro staging/rdma/hfi1: Split multiple assignments staging/rdma/hfi1: Fix misspellings staging/rdma/hfi1: Remove CamelCase staging/rdma/hfi1: Use pointer instead of struct name staging/rdma/hfi1: Remove void function return statement staging/rdma/hfi1: Add comment for spinlock_t definition staging/rdma/hfi1: Fix block comments staging/rdma/hfi1: Fix code alignment staging/rdma/hfi1: Add braces on all arms of statement staging/rdma/hfi1: Remove else after break staging/rdma/hfi1: Fix header

 drivers/staging/rdma/hfi1/affinity.c       |    5 
 drivers/staging/rdma/hfi1/affinity.h       |    5 
 drivers/staging/rdma/hfi1/aspm.h           |    5 
 drivers/staging/rdma/hfi1/chip.c           | 1200 +++++++++++++-------------
 drivers/staging/rdma/hfi1/chip.h           |   35 -
 drivers/staging/rdma/hfi1/chip_registers.h |    5 
 drivers/staging/rdma/hfi1/common.h         |    5 
 drivers/staging/rdma/hfi1/debugfs.c        |   47 -
 drivers/staging/rdma/hfi1/debugfs.h        |    5 
 drivers/staging/rdma/hfi1/device.c         |    5 
 drivers/staging/rdma/hfi1/device.h         |    5 
 drivers/staging/rdma/hfi1/diag.c           |    5 
 drivers/staging/rdma/hfi1/dma.c            |   17 
 drivers/staging/rdma/hfi1/driver.c         |   75 +-
 drivers/staging/rdma/hfi1/efivar.c         |    5 
 drivers/staging/rdma/hfi1/efivar.h         |    5 
 drivers/staging/rdma/hfi1/eprom.c          |   56 +
 drivers/staging/rdma/hfi1/eprom.h          |    5 
 drivers/staging/rdma/hfi1/file_ops.c       |   42 -
 drivers/staging/rdma/hfi1/firmware.c       |  177 ++--
 drivers/staging/rdma/hfi1/hfi.h            |   28 -
 drivers/staging/rdma/hfi1/init.c           |   49 +
 drivers/staging/rdma/hfi1/intr.c           |   24 -
 drivers/staging/rdma/hfi1/iowait.h         |    5 
 drivers/staging/rdma/hfi1/mad.c            |  342 ++++---
 drivers/staging/rdma/hfi1/mad.h            |   14 
 drivers/staging/rdma/hfi1/opa_compat.h     |    5 
 drivers/staging/rdma/hfi1/pcie.c           |  120 +--
 drivers/staging/rdma/hfi1/pio.c            |   99 +-
 drivers/staging/rdma/hfi1/pio.h            |   12 
 drivers/staging/rdma/hfi1/pio_copy.c       |   67 +
 drivers/staging/rdma/hfi1/platform.c       |    5 
 drivers/staging/rdma/hfi1/platform.h       |   13 
 drivers/staging/rdma/hfi1/qp.c             |   15 
 drivers/staging/rdma/hfi1/qp.h             |    5 
 drivers/staging/rdma/hfi1/qsfp.c           |   17 
 drivers/staging/rdma/hfi1/qsfp.h           |    8 
 drivers/staging/rdma/hfi1/rc.c             |   52 +
 drivers/staging/rdma/hfi1/ruc.c            |   27 -
 drivers/staging/rdma/hfi1/sdma.c           |  219 ++---
 drivers/staging/rdma/hfi1/sdma.h           |   23 
 drivers/staging/rdma/hfi1/sysfs.c          |   52 -
 drivers/staging/rdma/hfi1/trace.c          |   52 +
 drivers/staging/rdma/hfi1/trace.h          | 1289 +++++++++++++---------------
 drivers/staging/rdma/hfi1/twsi.c           |   11 
 drivers/staging/rdma/hfi1/twsi.h           |    6 
 drivers/staging/rdma/hfi1/uc.c             |   40 -
 drivers/staging/rdma/hfi1/ud.c             |   38 -
 drivers/staging/rdma/hfi1/user_exp_rcv.c   |    5 
 drivers/staging/rdma/hfi1/user_exp_rcv.h   |    5 
 drivers/staging/rdma/hfi1/user_pages.c     |    5 
 drivers/staging/rdma/hfi1/user_sdma.c      |   61 +
 drivers/staging/rdma/hfi1/user_sdma.h      |    5 
 drivers/staging/rdma/hfi1/verbs.c          |   27 -
 drivers/staging/rdma/hfi1/verbs.h          |    9 
 55 files changed, 2131 insertions(+), 2332 deletions(-)
Signature · 5 lines
-Denny
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html