Use nmi_panic() in panic on NMI case
Get series with b4
b4 am 20160303105741.4587.49047.stgit@softrsVersions newest first · linked by author and title
- v3 Latest3 patches 7 repliesIn review
- v23 patches 4 repliesSuperseded
- v13 patches 10 repliesSuperseded
Changes in v3 from the cover letter
- Make nmi_panic receive a single string instead of printf style args (PATCH 1/3)
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | panic: Change nmi_panic from macro to functioninclude/ kernel/ | +21 | 5 replies | |
| 2/3 | ipmi/watchdog: Use nmi_panic() when kernel panics in NMI handlerdrivers/ | +1 | 0 replies | |
| 3/3 | hpwdt: Use nmi_panic() when kernel panics in NMI handlerdrivers/ | +5 | 2 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Corey Minyard | Guenter Roeck | Michal Hocko | Borislav Petkov | Michal Nazarewicz |
|---|---|---|---|---|---|
| 1/3 | A-b | A-b | A-b | ||
| 2/3 | A-b | A-b | R-b | ||
| 3/3 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [v3 PATCH 0/3] Use nmi_panic() in panic on NMI case
commit 1717f2096b54 ("panic, x86: Fix re-entrance problem due to panic on NMI") and commit 58c5661f2144 ("panic, x86: Allow CPUs to save registers even if looping in NMI context") introduced nmi_panic() which prevents concurrent/recursive execution of panic(). It also saves registers for the crash dump on x86.
However, there are some cases where NMI handlers still use panic(). This patch set partially replaces them with nmi_panic() in those cases.
Changes since v2 (https://lkml.org/lkml/2016/3/2/173):
- Make nmi_panic receive a single string instead of printf style args (PATCH 1/3)
Changes since v1 (https://lkml.org/lkml/2016/2/29/858):
- Replace nmi_panic() macro with a function version instead of exporting symbols referred by the macro (PATCH 1/3)
- Improve the patch descriptions (PATCH 2/3 and 3/3)
- Do small cleanups (PATCH 3/3)
---
Even if applying this patch set, some NMI or similar handlers (e.g. MCE handler) remains to use panic(). This is because I can't test them well and actual problems won't happen. For example, the possibility that normal panic and panic on MCE happen simultaneously is very low.
Hidehiro Kawai (3):
panic: Change nmi_panic from macro to function ipmi/watchdog: Use nmi_panic() when kernel panics in NMI handler
hpwdt: Use nmi_panic() when kernel panics in NMI handler
drivers/char/ipmi/ipmi_watchdog.c | 2 +- drivers/watchdog/hpwdt.c | 11 +++++------ include/linux/kernel.h | 21 +-------------------- kernel/panic.c | 20 ++++++++++++++++++++ 4 files changed, 27 insertions(+), 27 deletions(-)
Signature · 2 lines
Hidehiro Kawai Hitachi, Ltd. Research & Development Group