Skip to content

pci: host: new driver for Marvell Armada 7K/8K PCIe controller

Bjorn Helgaas linux-arm-kernel linux-devicetree linux-pci 4 versions – New

Get series with b4
b4 am 20160426214510.GA6789@localhost

Versions newest first · linked by author and title

  1. v3 Latest posting 2/20 of 2 patches 0 repliesNew
  2. v3 posting 1/20 of 2 patches 0 repliesSuperseded
  3. v2 posting 2/20 of 2 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v2 posting 1/20 of 2 patches0 repliesSuperseded

Patches in v3 posting 2/2 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] pci: host: new driver for Marvell Armada 7K/8K PCIe controller
Quoted 15 lines · Thomas Petazzoni

Hello,

Quoted 4 lines · Bjorn Helgaas
Quoted 2 lines
 create mode 100644 Documentation/devicetree/bindings/pci/pci-armada8k.txt
 create mode 100644 drivers/pci/host/pcie-armada8k.c

Thanks, Thomas, I applied these to pci/host-armada for v4.7.

Thanks!

Quoted 3 lines

I added the tweaks below to use dev_dbg() instead of pr_debug(), use dw_pcie_wait_for_link() instead of another hand-coded timeout loop, and fix a typo and remove unused constants.

Quoted 8 lines

Looks all good, thanks for applying! Just one tiny question below.

Review

Quoted 4 lines
(quoted diff) +1 -1
 	/*
 	 * Interrupts are directly handled by the device driver of the
-	 * PCI device. However, there are also latched into the PCIe
+	 * PCI device.  However, they are also latched into the PCIe

Any reason to have two spaces after the dot here?

Only habit because my eighth-grade typing teacher in 1979 did it that way, and (I think) vim does it that way by default. Poor reasons, both, and definitely trumped by consistency with the rest of the file, which does use a single space in both other instances. I removed the extra space :)

Bjorn

Read the cover letter in its thread