Skip to content

RFC arm64: vdso: check whether the params is invalid address

Will Deacon linux-arm-kernel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/4] arm64: vdso: check whether the params is invalid address
Quoted 8 lines · Yang Yingliang

The params of gettimeofday(), clock_gettime() and clock_getres() is not checked. This will cause segment faults when the address is invalid.

E.g. gettimeofday(-1, -1);
     clock_gettime(0, -1);
     clock_getres(0, -1);

This patchset add a macro and use it to check the validation of these pointer params.

Is this really necessary? It doesn't look to me like other architectures bother with this, and you're just adding code to the fastpath to handle cases that shouldn't happen to start with.

Also, I think I remember seeing SEGVs from libc wrappers for other syscalls in the past, so this just isn't compelling to me.

Will

Read the cover letter in its thread