Skip to content

ARM: dts: sunxi: Fix simplefb not working in 4.7-rc1

Maxime Ripard linux-arm-kernel linux-devicetree 1 version New

Get series with b4
b4 am 20160620074610.GH26668@lukather

Versions newest first

  1. v1 Latest0 of 1 patch 0 repliesNew

Patches in v1 No applies recorded yet

The patch the cover letter announces is not in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] ARM: dts: sunxi: Fix simplefb not working in 4.7-rc1
Quoted 50 lines · Hans de Goede

Hi,

Quoted 33 lines · Maxime Ripard
Quoted 23 lines · Hans de Goede

Hi,

Quoted 9 lines · Maxime Ripard

Hi Hans,

Quoted 6 lines · Hans de Goede

Hi Maxime,

While testing 4.7-rc1 / linux-sunxi/sunxi-next on a A10s I noticed that hdmi out is no longer working (screen goes black when the kernel turns of unused clocks).

Quoted 5 lines
Quoted 3 lines

This is caused by the dtsi for sun4i / sun5i / sun7i based boards now listing pll3, without pll3 being added to the clocks list for the simplefb nodes.

Why not do just that then? It's more appropriate for a fix imho.

You mean just for sun5i-a10s, or for all of sun4i / sun5i-a10s and sun7i ?

For sun4i and sun7i things are already fixed in next:

Quoted 8 lines

https://git.kernel.org/cgit/linux/kernel/git/mripard/linux.git/commit/?id=5a7f2310cc847a73852e70bc720a61ca9bf986a6
https://git.kernel.org/cgit/linux/kernel/git/mripard/linux.git/commit/?id=c79255ca4d7b67cce4eac4dd532e097ce49f3679

It seems best to use those fixes, rather then come up with a separate fix for 4.7.

My patch for fixing sun5i-a10s is inline with the 2 above patches, which seems best, rather then doing something special for just sun5i-a10s.

Quoted 6 lines

Well, you are doing something special for just the A10s: the patches quoted above just add a bunch of clocks and add the handles to the list of clocks managed by simplefb.

For the A10s, you also declare the whole display engine block without anyone having tested that it was actually working.

A10s is the same SoC as A13 / R8, just in a different package / with different pins routed to the outside and it features a parallel LCD interface just like the A13 / R8. We've had this confirmed by Allwinner multiple times now, A13 / A10s / R8 literary are the same chip, there simply is no way the displayblock on the A10s somehow is magically different.

Quoted 2 lines

Given all this, clearly having this identical displayblock in the shared sun5i.dtsi is the right thing to do.

Maybe, but this is not a patch for an 4.7-rc* release, but for the next merge window.

Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160620/a8fa6795/attachment.sig>