Skip to content

git worktree (re)move

Nguyễn Thái Ngọc Duy git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10copy.c: import copy_file() from busyboxcopy.c+331 -00 replies
2/10copy.c: delete unused code in copy_file()copy.c+7 -940 replies
3/10copy.c: convert bb_(p)error_msg to error(_errno)copy.c+31 -540 replies
4/10copy.c: style fixcopy.c+29 -210 replies
5/10copy.c: convert copy_file() to copy_dir_recursively()cache.h copy.c+179 -381 reply
6/10worktree.c: add validate_worktree()worktree.c worktree.h+68 -00 replies
7/10worktree.c: add update_worktree_location()worktree.c worktree.h+31 -01 reply
8/10worktree: add "move" commmandDocumentation/git-worktree.txt builtin/worktree.c contrib/completion/git-completion.bash +1 more+98 -21 reply
9/10worktree move: accept destination as directorybuiltin/worktree.c+18 -10 replies
10/10worktree: add "remove" commandDocumentation/git-worktree.txt builtin/worktree.c contrib/completion/git-completion.bash +1 more+120 -101 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] git worktree (re)move

Now that nd/worktree-lock seems to be on its way to 'next', let's continue to review this one. The first 5 patches bring busybox's copy functionality to git. The last 5 add support functions and the two new commands.

This series needs both nd/worktree-lock (for find_worktree) and 'master' (for error_errno).

Nguyễn Thái Ngọc Duy (10):
copy.c: import copy_file() from busybox copy.c: delete unused code in copy_file() copy.c: convert bb_(p)error_msg to error(_errno) copy.c: style fix
copy.c: convert copy_file() to copy_dir_recursively() worktree.c: add validate_worktree() worktree.c: add update_worktree_location()
worktree: add "move" commmand
worktree move: accept destination as directory
worktree: add "remove" command

 Documentation/git-worktree.txt         |  28 ++-
 builtin/worktree.c                     | 156 ++++++++++++++
 cache.h                                |   1 +
 contrib/completion/git-completion.bash |   5 +-
 copy.c                                 | 369 +++++++++++++++++++++++++++++++++
 t/t2028-worktree-move.sh               |  56 +++++
 worktree.c                             |  88 ++++++++
 worktree.h                             |  11 +
 8 files changed, 703 insertions(+), 11 deletions(-)
Signature · 1 line
2.8.2.526.g02eed6d