Skip to content

cpufreq: pcc-cpufreq: Re-introduce deadband effect to reduce number of frequency changes

Andreas Herrmann linux-pm lkml 2 versions – NAK

Status from this message: NAK.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesNAK
  2. v11 patch 14 repliesSuperseded

Patches in v2

#Subject and filesSizeRepliesApplied
1/2cpufreq/ondemand: Introduce op to customize mapping of load to frequencydrivers/cpufreq/cpufreq_governor.h drivers/cpufreq/cpufreq_ondemand.c+35 -52 replies
2/2cpufreq/pcc-cpufreq: Make use of map_load_to_freq opdrivers/cpufreq/pcc-cpufreq.c+11 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] cpufreq: pcc-cpufreq: Re-introduce deadband effect to reduce number of frequency changes

Hi,

following patches address the performance degradation due to commit 6393d6a102 (cpufreq: ondemand: Eliminate the deadband effect) on systems using pcc-cpufreq driver and ondemand governor.

Patch 1 introduces a generic_map_load_to_freq function which is similar to what is used since commit 6393d6a102 (cpufreq: ondemand:
Eliminate the deadband effect) to calculate freq_next in od_update.

Patch 2 provides a specific function for pcc-cpufreq driver which falls back to the calculation that was in the used before commit 6393d6a102.

I've also tested a pcc-specific function without deadband effect but using only 10 frequency values. That was suboptimal in comparison to patch 2. Here the performance data for this comparison (kernel compilation with different number of jobs):

pcc specific map_load_to_freq pcc specific map_load_to_freq
function (with deadband) function (10 frequency steps)

 # of jobs  user    sys   elapsed   % CPU      user    sys   elapsed   % CPU
    2      413.19  102.34  250.97   205.00    426.21  106.32  260.00   204.00
    4      390.56  120.79  127.25   401.20    408.38  124.03  132.63   401.00
    8      354.22  140.09   64.20   769.60    383.33  146.31   68.70   770.40
   16      384.20  148.69   37.07  1436.60    466.20  164.18   43.30  1455.00
   32      496.70  152.77   25.15  2581.40    658.50  179.74   31.27  2680.60
   64      399.48   49.13   12.80  3505.80    404.27   51.24   13.14  3467.00
  120      406.52   46.89   13.60  3331.60    409.42   48.71   13.58  3371.40

Regards,

Andreas