Skip to content

Series of patch to improve Buildroot configuration for

Thomas Petazzoni buildroot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 of 11 patches 0 repliesNew

7 of 11 patches are in this archive. The cover letter announces 11.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11Update genimage configuration file for Arietta-G25 in order to build a bootable SD card image named "sdcard.img"+0 -00 replies
2/11Add Linux Kernel stable 4.4.16 patch file for Arietta G25+0 -00 replies
2/11Add Linux Kernel stable 4.4.16 patch file for Arietta G25+0 -00 replies
3/11Add post-build.sh script for Arietta G25+0 -00 replies
4/11Add root filesystem overlay files and directories for Arietta G25+0 -00 replies
5/11Update and improve default configuration files for Arietta G25 (both 128MB and 256MB version)+0 -00 replies
7/11Add Linux Kernel stable v4.4.16 patch file for Aria G25+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Buildroot] [PATCH 00/11] Series of patch to improve Buildroot configuration for

Hello,

Quoted 16 lines · Biagio Montaruli

Biagio Montaruli (11):
Update genimage configuration file for Arietta-G25 in order to build
a bootable SD card image named "sdcard.img"
Add Linux Kernel stable 4.4.16 patch file for Arietta G25 Add post-build.sh script for Arietta G25
Add root filesystem overlay files and directories for Arietta G25 Update and improve default configuration files for Arietta G25

    (both 128MB and 256MB version)
  Update README file for Arietta G25 named "readme.txt"
  Add Linux Kernel stable v4.4.16 patch file for Aria G25
  Add post-build.sh script for Aria G25
  Update genimage configuration file and add post-image.sh script for   
     Aria G25 in order to build a bootable SD card image named
    "sdcard.img"
  Update and improve default configuration files for Arietta G25    
    (both 128MB and 256MB version)
Quoted 1 line

Update README file for Aria G25 named "readme.txt"

Thanks for this patch series, and sorry for the slow response. However, there is a big problem with this patch series: it is not bisectable. For example, if I apply just your first patch, it breaks the build of the Arietta G25 defconfig. Patch series should be bisectable, i.e I should be able to apply patches 1 to 3 in your patch series, and still have a working solution.

In your case, I believe that it would be preferable to have one patch updating the Arietta configuration entirely (kernel patches, kernel configuration, Buildroot defconfig, etc.), and similarly one patch for the Aria configuration.

Also, using proper commit title would be better, like:

configs/acmesystems_arietta_g25: update with newer kernel

I'll comment separately on the different patches.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Read the cover letter in its thread