Skip to content

arm64: kgdb: fix single stepping

Greg KH linux-arm-kernel stable 2 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/20 of 3 patches 0 repliesNew
  2. v2 posting 1/20 of 3 patches 0 repliesSuperseded

Patches in v2 posting 2/2 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] arm64: kgdb: fix single stepping
Quoted 22 lines · AKASHI Takahiro
Quoted 21 lines · Greg KH
Quoted 20 lines · AKASHI Takahiro
Quoted 11 lines · Greg KH
Quoted 7 lines · AKASHI Takahiro

Kgdb support on arm64 was merged in v3.15, but from its first appearance, "signle step" has never worked well.

This patch fixes all the error cases I found so far.
The original patch[1] was splitted into three pieces, ones for each case. patch#1, #2 should be applied to all the version, v3.15 and later. pathc#3 only for v3.16 and later.

As this is not a regression (i.e. it has never worked), why is this something for stable releases?

Because, I think, that is a bug.
The author seems to have believed that it worked. Please see:
commit 44679a4f
Author: Vijaya Kumar K <[email protected]>
Date: Tue Jan 28 11:20:19 2014 +0000

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

arm64: KGDB: Add step debugging support

Yes, but again, it didn't work, so this would be a new feature.

Yes, but again, it's a bug of kgdb on arm64 which is supposed to have been available since v3.15.

But it wasn't ever working, so it's not a regression or a bugfix, sorry.

Quoted 4 lines
Quoted 2 lines

Please read Documentation/stable_kernel_rules.txt for the requirements of a stable kernel patch. I don't think this series meets those rules.

Please re-think about merging this patch.

It's not even in Linus's tree yet, so there's nothing for me to merge anywhere.

thanks,

greg k-h