Skip to content

(Was: BUG_ON in rcu_sync_func triggered)

Oleg Nesterov fstests linux-fsdevel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2fs/super.c: fix race between freeze_super() and thaw_super()fs/super.c+3 -31 reply
2/2fs/super.c: don't fool lockdep in freeze_super() and thaw_super() pathsfs/super.c+25 -1225 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchNikolay BorisovJan Kara
1/2Reported-and-tested-by R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] (Was: BUG_ON in rcu_sync_func triggered)

Hello,

The patches do not depend on each other.

1/2 is the trivial fix, imo -stable material. The bug is very old it seems, but today this race (leading to unbalanced unlock) manifests itself via mysterious BUG_ON's in rcu/sync.c.

2/2 is old, I forgot to send it before. It was already reviewed by Dave and Jan, but the generic/068 test from xfstests triggered the warning. This was fixed by dbad7c993053 "xfs: stop holding ILOCK over filldir callbacks" so we can hopefully kill the early-lockdep-release kludge.

Oleg.

 fs/super.c | 43 ++++++++++++++++++++++++++++---------------
 1 file changed, 28 insertions(+), 15 deletions(-)