Skip to content

RFC Patch series to fix autofs unreliable usage of d_mountpoint()

Ian Kent autofs linux-fsdevel lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest8 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8vfs - change d_manage() to take a struct pathDocumentation/filesystems/Locking Documentation/filesystems/vfs.txt fs/autofs4/root.c +2 more+12 -120 replies
2/8vfs - add path_is_mountpoint() helperfs/namespace.c include/linux/fs.h+45 -00 replies
3/8vfs - add path_has_submounts()fs/dcache.c include/linux/dcache.h+36 -00 replies
4/8autofs - change autofs4_expire_wait() to take struct pathfs/autofs4/autofs_i.h fs/autofs4/dev-ioctl.c fs/autofs4/expire.c +1 more+11 -80 replies
5/8autofs - change autofs4_wait() to take struct pathfs/autofs4/autofs_i.h fs/autofs4/expire.c fs/autofs4/root.c +1 more+14 -120 replies
6/8autofs - use path_is_mountpoint() to fix unreliable d_mountpoint() checksfs/autofs4/root.c+16 -80 replies
7/8autofs - use path_has_submounts() to fix unreliable have_submount() checksfs/autofs4/dev-ioctl.c fs/autofs4/root.c fs/autofs4/waitq.c+15 -110 replies
8/8vfs - remove unused have_submounts() functionfs/dcache.c include/linux/dcache.h+0 -340 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/8] Patch series to fix autofs unreliable usage of d_mountpoint()

This series fixes the potential problem of autofs returning ELOOP when a mount exists in a propogation private mount namespace other than the namespace in which the mount is to be performed.

I'm posting the series as an RFC in the hope of catching stupid mistakes that I may have made before submitting to mmotm. Please note the series here is against the current Linus tree and may be slightly different when posted for inclusion in mmotm.

Please review and post any comments.
---

Ian Kent (8):
vfs - change d_manage() to take a struct path
vfs - add path_is_mountpoint() helper
vfs - add path_has_submounts()
autofs - change autofs4_expire_wait() to take struct path autofs - change autofs4_wait() to take struct path
autofs - use path_is_mountpoint() to fix unreliable d_mountpoint() checks autofs - use path_has_submounts() to fix unreliable have_submount() checks vfs - remove unused have_submounts() function

 Documentation/filesystems/Locking |    2 +
 Documentation/filesystems/vfs.txt |    2 +
 fs/autofs4/autofs_i.h             |    4 +-
 fs/autofs4/dev-ioctl.c            |    4 +-
 fs/autofs4/expire.c               |    8 +++-
 fs/autofs4/root.c                 |   71 +++++++++++++++++++++----------------
 fs/autofs4/waitq.c                |   13 +++++--
 fs/dcache.c                       |   36 ++++++++++---------
 fs/namei.c                        |   13 +++----
 fs/namespace.c                    |   43 ++++++++++++++++++++++
 include/linux/dcache.h            |    4 +-
 include/linux/fs.h                |    2 +
 12 files changed, 133 insertions(+), 69 deletions(-)

--
Ian