Skip to content

Some possible additions to the DM ioctl patch for strace

Eugene Syromyatnikov dm-devel 1 version New

Get series with b4
b4 am 20161009132752.GA28054@obsidian

Versions newest first

  1. v1 Latest21 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21tests/ioctl_dm: Formattingtests/ioctl_dm.c+35 -70 replies
2/21dm: whitespace fixesdm.c+52 -350 replies
3/21tests: Working around bounds checktests/ioctl_dm.c+2 -10 replies
4/21dm: Minor output tweaksdm.c tests/ioctl_dm.c+14 -90 replies
5/21xlat: Add values for dm_flagsxlat/dm_flags.in+18 -180 replies
6/21dm: Some future-proofing by means of compile-time DM_VERSION_MAJOR checkdm.c+12 -10 replies
7/21dm: Add definitions for ioctl commands not implemented initiallydm.c+13 -00 replies
8/21dm: Use static constants for offset sizesdm.c+31 -270 replies
9/21dm: Remove char * castdm.c+1 -10 replies
10/21dm: use => instead of , for splitting output structure from inputdm.c tests/ioctl_dm.c+8 -80 replies
11/21dm: Compare entering field values with exiting onesdm.c tests/ioctl_dm.c+64 -360 replies
12/21dm: Add inttypes.h, include reorderdm.c tests/ioctl_dm.c+3 -10 replies
13/21dm: Move printing of dm_ioctl fields before allocation of extra datadm.c+4 -30 replies
14/21dm: replace abbrev branching with gotodm.c+40 -380 replies
15/21dm: Additional data_size/data_start checksdm.c+7 -10 replies
16/21dm: Add comment regarding intended fall-through in switch statementdm.c+1 -00 replies
17/21dm: Add data_size and data_offset fields to outputdm.c tests/ioctl_dm.c+27 -180 replies
18/21tests/ioctl_dm: Allow passing size and data_start to init_stests/ioctl_dm.c+16 -180 replies
19/21dm: Add check whether command uses parametersdm.c tests/ioctl_dm.c+23 -40 replies
20/21dm: Fix printing of version fielddm.c+5 -10 replies
21/21dm: rewrite structure decodingdm.c+217 -1460 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/21] Some possible additions to the DM ioctl patch for strace

Hello.

I've took the liberty to look at the patch and I'd like to propose some changes to it. Can you please review them from the DM side of things? I'm not quite sure I've understood all the specifics of the interface correctly, it's quite peculiar.

I'm also preparing a patch for the DM ioctl decoder test, but it's not ready yet.

Eugene Syromyatnikov (21):
tests/ioctl_dm: Formatting
dm: whitespace fixes
tests: Working around bounds check
dm: Minor output tweaks
xlat: Add values for dm_flags
dm: Some future-proofing by means of compile-time DM_VERSION_MAJOR
check
dm: Add definitions for ioctl commands not implemented initially
dm: Use static constants for offset sizes
dm: Remove char * cast
dm: use => instead of , for splitting output structure from input
dm: Compare entering field values with exiting ones
dm: Add inttypes.h, include reorder
dm: Move printing of dm_ioctl fields before allocation of extra data
dm: replace abbrev branching with goto
dm: Additional data_size/data_start checks
dm: Add comment regarding intended fall-through in switch statement
dm: Add data_size and data_offset fields to output tests/ioctl_dm: Allow passing size and data_start to init_s
dm: Add check whether command uses parameters
dm: Fix printing of version field
dm: rewrite structure decoding

 dm.c             |  549 ++++++++++++++++++++++++++++++++++++------------------
 tests/ioctl_dm.c |   79 +++++---
 xlat/dm_flags.in |   36 ++--
 3 files changed, 442 insertions(+), 222 deletions(-)
Signature · 6 lines
1.7.10.4


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot