Skip to content

Silence test-vmstate errors

Dr. David Alan Gilbert (git) qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tests/stubs: Add a dummy, silent monitorstubs/mon-is-qmp.c tests/libqtest.h+10 -01 reply
2/2test-vmstate: Silence expected errorstests/test-vmstate.c+8 -02 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarkus Armbruster
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/2] Silence test-vmstate errors

From: "Dr. David Alan Gilbert" <[email protected]>

In a1771070e7 I added an error message during migration loading so you could see the field that failed to load. Unfortunately this triggers during the expected-failure case testing in tests/test-vmstate.

This silences that error by providing a dummy monitor pointer that doesn't output anything and then selecting it around the noisy part of the test.

(I couldn't find anywhere better than libqtest.h for the declaration but stubs doesn't have it's own header; is it worth creating one just for that?)

Dave

Dr. David Alan Gilbert (2):
tests/stubs: Add a dummy, silent monitor
test-vmstate: Silence expected errors

 stubs/mon-is-qmp.c   | 9 +++++++++
 tests/libqtest.h     | 1 +
 tests/test-vmstate.c | 8 ++++++++
 3 files changed, 18 insertions(+)
Signature · 1 line
2.9.3