Skip to content

Input: ALPS - Bug fix and cleanup for SS5 hardware

Paul Donohue linux-input 6 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 0 repliesNew
  2. v53 patches 8 repliesSuperseded
  3. v43 patches 6 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v32 of 3 patches1 replySuperseded
v21 patch2 repliesSuperseded
v11 patch3 repliesSuperseded

Changes in v6 from the cover letter

* Added Reviewed-by: Pali Rohár <[email protected]>
* No code changes

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Input: ALPS - Fix TrackStick support for SS5 hardwaredrivers/input/mouse/alps.c+12 -70 replies
2/3Input: ALPS - Clean up TrackStick handling for SS5 hardwaredrivers/input/mouse/alps.c+25 -170 replies
3/3Input: ALPS - Clean up code for SS5 hardwaredrivers/input/mouse/alps.c drivers/input/mouse/alps.h+29 -170 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPali Rohár
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/3] Input: ALPS - Bug fix and cleanup for SS5 hardware

This series includes a bug fix and assorted cleanup for the Alps SS5 (SS4 v2) code.

Changes in v6:
* Added Reviewed-by: Pali Rohár <[email protected]>
* No code changes

Changes in v5:
* Moved TrackStick decoding logic to alps_process_packet_ss4_v2() to make the code more consistent with other protocol versions (Suggested by Pali Rohár <[email protected]>)

Changes in v4:
* Fixed patch formatting issues
* Correct casting issues in macros added in v3

Changes in v3:
* Added additional code cleanup to make the code easier to understand (Suggested by Pali Rohár <[email protected]>)

Changes in v2:
* For consistency with other Alps functions, check packet bytes for packet type rather than adding a flag to alps_fields for packet type. (Suggested by Pali Rohár <[email protected]>)

Paul Donohue (3):
Input: ALPS - Fix TrackStick support for SS5 hardware
Input: ALPS - Clean up TrackStick handling for SS5 hardware
Input: ALPS - Clean up code for SS5 hardware

 drivers/input/mouse/alps.c | 59 +++++++++++++++++++++++++---------------------
 drivers/input/mouse/alps.h | 22 ++++++++++++++++-
 2 files changed, 53 insertions(+), 28 deletions(-)
Signature · 1 line
2.7.4