Skip to content

Current patch queue for review

Ian Kent autofs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest37 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/37autofs-5.1.2 - fix release date in CHANGELOGCHANGELOG+5 -10 replies
2/37autofs-5.1.2 - build: check for clock_gettime in librtCHANGELOG Makefile.conf.in Makefile.rules +2 more+54 -00 replies
3/37autofs-5.1.2 - Fix compiler warning in try_remount()CHANGELOG lib/mounts.c+3 -30 replies
4/37autofs-5.1.2 - Drop redundant \n in logerr()CHANGELOG daemon/module.c lib/nss_parse.y+3 -20 replies
5/37autofs-5.1.2 - Fix size arg of fgets(3)CHANGELOG lib/defaults.c+2 -10 replies
6/37autofs-5.1.2 - fix libtirpc detection with -Wl, --as-neededCHANGELOG aclocal.m4 configure+7 -60 replies
7/37autofs-5.1.2 - Fix a typo in CREDITSCHANGELOG CREDITS+2 -10 replies
8/37autofs-5.1.2 - Change .requestor to .requester for consistencyCHANGELOG daemon/automount.c include/automount.h +3 more+12 -110 replies
9/37autofs-5.1.2 - fix file map changed checkCHANGELOG modules/lookup_file.c+5 -50 replies
10/37autofs-5.1.2 - Remove unused local 2KB bufferCHANGELOG daemon/automount.c+1 -30 replies
11/37autofs-5.1.2 - Fix typos in error messagesCHANGELOG daemon/automount.c daemon/state.c+5 -40 replies
12/37autofs-5.1.2 - Fix fgets(3) size argument (another one)CHANGELOG daemon/module.c+2 -10 replies
13/37autofs-5.1.2 - fix short memory allocation in lookup_amd_instance()CHANGELOG daemon/lookup.c+2 -10 replies
14/37autofs-5.1.2 - fix count_mounts() functionCHANGELOG daemon/automount.c+2 -10 replies
15/37autofs-5.1.2 - configure: add cache variable for Linux proc filesystem checkCHANGELOG aclocal.m4 configure+14 -180 replies
16/37autofs-5.1.2 - Avoid local variable name shadowing anotherCHANGELOG daemon/automount.c+2 -50 replies
17/37autofs-5.1.2 - fix typo in MOUNT_FLAG_GHOST commentinclude/automount.h+1 -10 replies
18/37autofs-5.1.2 - fix cachefs parse message not being loggedmodules/amd_parse.y+1 -00 replies
19/37autofs-5.1.2 - fix argc off by one in mount_autofs.cCHANGELOG modules/mount_autofs.c+5 -40 replies
20/37autofs-5.1.2 - fix _strncmp() usageCHANGELOG modules/mount_autofs.c modules/mount_ext2.c+8 -70 replies
21/37autofs-5.1.1 - fix create_client() RPC client handlingCHANGELOG lib/rpc_subs.c+9 -130 replies
22/37autofs-5.1.2 - update and add README for old autofs schemaCHANGELOG README.autofs-schema samples/autofs.schema+29 -140 replies
23/37autofs-5.1.2 - wait for master map available at startCHANGELOG daemon/automount.c daemon/lookup.c +4 more+108 -180 replies
24/37autofs-5.1.2 - add master read wait optionCHANGELOG daemon/automount.c include/defaults.h +5 more+52 -20 replies
25/37autofs-5.1.2 - work around sss startup delayCHANGELOG modules/lookup_sss.c+62 -00 replies
26/37autofs-5.1.2 - add sss master map wait config optionCHANGELOG include/defaults.h lib/defaults.c +4 more+53 -30 replies
27/37autofs-5.1.2 - fix typos in README.amd-mapsCHANGELOG README.amd-maps+9 -70 replies
28/37autofs-5.1.2 - add ref counting to struct map_sourceCHANGELOG daemon/indirect.c include/master.h +2 more+73 -210 replies
29/37autofs-5.1.2 - add support for amd browsable optionCHANGELOG README.amd-maps daemon/lookup.c +7 more+120 -370 replies
30/37autofs-5.1.2 - add function conf_amd_get_map_name()CHANGELOG include/defaults.h lib/defaults.c+12 -00 replies
31/37autofs-5.1.2 - add function conf_amd_get_mount_paths()CHANGELOG include/defaults.h lib/defaults.c+82 -00 replies
32/37autofs-5.1.2 - include amd mount section mounts in master mounts listCHANGELOG README.amd-maps lib/master.c+152 -70 replies
33/37autofs-5.1.2 - check for conflicting amd section mountsCHANGELOG include/master.h lib/master.c+58 -30 replies
34/37autofs-5.1.2 - add function conf_get_map_options()CHANGELOG include/defaults.h lib/defaults.c+12 -00 replies
35/37autofs-5.1.2 - capture cache option and its settings during parsingCHANGELOG include/parse_amd.h modules/amd_parse.y +1 more+18 -40 replies
36/37autofs-5.1.2 - handle map_option cache for top level mountsCHANGELOG include/automount.h lib/master.c +2 more+41 -20 replies
37/37autofs-5.1.2 - handle amd cache option all in amd type auto mountsCHANGELOG modules/lookup_ldap.c modules/lookup_nisplus.c +3 more+28 -160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/37] Current patch queue for review

Hi all,

The patch queue is well overdue for a commit but since there's been increased contributions for others recently I thought it would be useful to post the patches for review and give a brief description of what's in the queue and what still needs work.

Many of the patches are striaght forward and I expect to commit then in a week or so. Also keep in mind the commit order might be different when the commit is actually done.

The patches around those titled "autofs-5.1.2 - wait for master map available at start" and "autofs-5.1.2 - add master read wait option" have been around for quite a while and have been a problem in the past (which is why they haven't been committed yet) so I'm not sure about them yet.

The series to add browse support for amd maps is not yet complete so they will likely stay in the queue a bit longer. But I am keen to get this functionality into a release as I know it is something that at least a few people would like.

Anyway review of the patches would be appreciated.

---

Gustavo Zacarias (1):
autofs-5.1.2 - build: check for clock_gettime in librt

Ian Kent (25):
autofs-5.1.2 - fix release date in CHANGELOG
autofs-5.1.2 - fix file map changed check
autofs-5.1.2 - fix short memory allocation in lookup_amd_instance() autofs-5.1.2 - fix count_mounts() function
autofs-5.1.2 - fix typo in MOUNT_FLAG_GHOST comment autofs-5.1.2 - fix cachefs parse message not being logged autofs-5.1.2 - fix argc off by one in mount_autofs.c autofs-5.1.2 - fix _strncmp() usage
autofs-5.1.1 - fix create_client() RPC client handling autofs-5.1.2 - update and add README for old autofs schema autofs-5.1.2 - wait for master map available at start autofs-5.1.2 - add master read wait option
autofs-5.1.2 - work around sss startup delay
autofs-5.1.2 - add sss master map wait config option autofs-5.1.2 - fix typos in README.amd-maps
autofs-5.1.2 - add ref counting to struct map_source autofs-5.1.2 - add support for amd browsable option autofs-5.1.2 - add function conf_amd_get_map_name() autofs-5.1.2 - add function conf_amd_get_mount_paths() autofs-5.1.2 - include amd mount section mounts in master mounts list autofs-5.1.2 - check for conflicting amd section mounts autofs-5.1.2 - add function conf_get_map_options() autofs-5.1.2 - capture cache option and its settings during parsing autofs-5.1.2 - handle map_option cache for top level mounts autofs-5.1.2 - handle amd cache option all in amd type auto mounts

Martin von Gagern (1):
autofs-5.1.2 - fix libtirpc detection with -Wl,--as-needed

Thomas Petazzoni (1):
autofs-5.1.2 - configure: add cache variable for Linux proc filesystem check

Tomohiro Kusumi (9):
autofs-5.1.2 - Fix compiler warning in try_remount() autofs-5.1.2 - Drop redundant \n in logerr() autofs-5.1.2 - Fix size arg of fgets(3) autofs-5.1.2 - Fix a typo in CREDITS
autofs-5.1.2 - Change .requestor to .requester for consistency autofs-5.1.2 - Remove unused local 2KB buffer autofs-5.1.2 - Fix typos in error messages autofs-5.1.2 - Fix fgets(3) size argument (another one) autofs-5.1.2 - Avoid local variable name shadowing another

 CHANGELOG                      |   40 ++++++++
 CREDITS                        |    2 
 Makefile.conf.in               |    3 +
 Makefile.rules                 |    2 
 README.amd-maps                |   64 ++++++++++---
 README.autofs-schema           |   18 ++++
 aclocal.m4                     |   21 ++--
 configure                      |   66 +++++++++++--
 configure.in                   |    4 +
 daemon/automount.c             |  107 +++++++++++++++++----
 daemon/indirect.c              |    7 +
 daemon/lookup.c                |  116 +++++++++++++++++++----
 daemon/module.c                |    4 -
 daemon/state.c                 |    4 -
 include/automount.h            |    9 +-
 include/defaults.h             |    8 ++
 include/dev-ioctl-lib.h        |    2 
 include/master.h               |    4 +
 include/parse_amd.h            |    7 +
 lib/defaults.c                 |  137 +++++++++++++++++++++++++++
 lib/dev-ioctl-lib.c            |   10 +-
 lib/master.c                   |  202 ++++++++++++++++++++++++++++++++++++++++
 lib/master_parse.y             |   30 +++++-
 lib/mounts.c                   |    9 +-
 lib/nss_parse.y                |    2 
 lib/rpc_subs.c                 |   21 ++--
 man/autofs.conf.5.in           |   27 +++++
 man/automount.8                |    4 +
 modules/amd_parse.y            |   16 ++-
 modules/amd_tok.l              |    2 
 modules/lookup_file.c          |   15 ++-
 modules/lookup_ldap.c          |   10 +-
 modules/lookup_nisplus.c       |   24 +++--
 modules/lookup_sss.c           |   72 +++++++++++++-
 modules/lookup_yp.c            |   23 +++--
 modules/mount_autofs.c         |   84 +++++++++++------
 modules/mount_ext2.c           |    2 
 modules/parse_amd.c            |    2 
 redhat/autofs.conf.default.in  |   24 ++++-
 samples/autofs.conf.default.in |   24 ++++-
 samples/autofs.schema          |   24 ++---
 41 files changed, 1042 insertions(+), 210 deletions(-)
 create mode 100644 README.autofs-schema

--
Ian
--
To unsubscribe from this list: send the line "unsubscribe autofs" in