Skip to content

ARM: imx31: clock initialization fixes

Stephen Boyd linux-arm-kernel linux-clk 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 of 4 patches 0 repliesNew

2 of 4 patches are in this archive. The cover letter announces 4.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
3/4clk: imx31: fix rewritten input argument of mx31_clocks_init()+0 -00 replies
4/4ARM: clk: imx31: properly init clocks for machines with DT+0 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchStephen Boyd
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] ARM: imx31: clock initialization fixes
Quoted 32 lines · Shawn Guo
Quoted 25 lines · Vladimir Zapolskiy

The change is tested on qemu kzm target and mx31lite board, while both targets don't have DTS in upstream, I had to write simple DTS files for them, because the proposed change is for i.MX31 targets with OF support.

i.MX31/OF/clock initialization seems to be broken currently, if the series is not applied I can not get a working clock source during early boot stage on a board with DTB supplied.

Changes from v1 to v2, thanks to Uwe and Stephen for review:
* added one more new fix in imx31.dtsi which moves CCM device node to AIPS2 bus,
* included to the series a fix of CCM interrupts in imx31.dtsi, the change was sent as a separate patch, the change is included to avoid a patch application dependency,
* as suggested by Uwe reworded one of the commits removing "stack corruption" mentioning, the overwritten value is passed in a register,
* as suggested by Uwe squashed clk-imx31.c and imx31-dt.c changes to avoid a runtime problem if only one of two patches are applied

Vladimir Zapolskiy (4):
ARM: dts: imx31: fix clock control module interrupts description
ARM: dts: imx31: move CCM device node to AIPS2 bus devices
clk: imx31: fix rewritten input argument of mx31_clocks_init()
ARM: clk: imx31: properly init clocks for machines with DT

Quoted 5 lines
 .../devicetree/bindings/clock/imx31-clock.txt      |  2 +-
 arch/arm/boot/dts/imx31.dtsi                       | 14 +++---
 arch/arm/mach-imx/common.h                         |  1 -
 arch/arm/mach-imx/imx31-dt.c                       |  6 ---
 drivers/clk/imx/clk-imx31.c                        | 52 +++++++++++-----------
Quoted 5 lines

Hi Stephen,

Can I have you ACK on the clk file, so that we can merge the series from arm-soc tree? Thanks.

Done.

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project