Skip to content

security: apparmor: apparmorfs.c Checkpatch mods

Greg KH kernelnewbies 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 7 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 7 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods
Quoted 45 lines · Walt Feasel
Quoted 44 lines · Greg KH
Quoted 27 lines · Walt Feasel
Quoted 20 lines · Greg KH
Quoted 10 lines · Walt Feasel

Make checkpatch modifications to include:

Multiple blank lines
Blank line after declarations
Space after cast
WARN_ON vs BUG_ON
Align parenthesis
Comparison to NULL
Line continuations

Quoted 8 lines

Walt Feasel (7):
security: apparmor: apparmorfs.c Multiple blank lines
security: apparmor: apparmorfs.c Blank line after declarations
security: apparmor: apparmorfs.c Space after cast
security: apparmor: apparmorfs.c WARN_ON vs BUG_ON
security: apparmor: apparmorfs.c Align parenthesis
security: apparmor: apparmorfs.c Comparison to NULL
security: apparmor: apparmorfs.c Line continuations

Quoted 6 lines

Why are you sending apparmor patches to the kernelnewbies list and not the maintainers and subsystem list for this code instead?

thanks,

greg k-h

Quoted 11 lines

Because as stated in my patch notes I am not sure how to fix certain cases.
I have not been able to find reference material other than other patches and discussions for certain cases and have to try and reason why.
You wanted me to move out of staging so I have looked to other areas but do not wish to send in ridiculous patches and have me seen as being malicious.
Since this is kernelnewbies mailing list isn't that it's purpose or am I move on again?
Feel free to skip my post should they trouble you.

Just send the patches to the proper people and list that get_maintainer.pl shows you to, that's all, no need to bother kernelnewbies with it.

Quoted 5 lines
Quoted 3 lines

good luck!

greg k-h

So kernelnewbies is not to be used to learn about how to fix checkpatch type warning?

Maybe, but really, if you have a well-formed patch, just send it to the correct maintainers, it's up to them to accept it or not, that's their job :)

greg k-h