Skip to content

use mmu gather logic for tlb flush in mremap

Aaron Lu linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tlb: export tlb_flush_mmu_tlbonlyinclude/asm-generic/tlb.h mm/memory.c+2 -10 replies
2/2mremap: use mmu gather logic for tlb flush in mremapinclude/linux/huge_mm.h mm/huge_memory.c mm/mremap.c+25 -247 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] use mmu gather logic for tlb flush in mremap
Quoted 7 lines · Aaron Lu
Quoted 5 lines · Linus Torvalds

I'm not entirely happy with the force_flush vs need_flush games, and I really think this code should be updated to use the same "struct mmu_gather" that we use for the other TLB flushing cases (no need for the page freeing batching, but the tlb_flush_mmu_tlbonly() logic should be the same).

Quoted 8 lines

I see.

Quoted 4 lines

But I guess that's a bigger change, so that wouldn't be approriate for rc5 or stable back-porting anyway. But it would be lovely if somebody could look at that. Hint hint.

I'll work on it, thanks for the suggestion.

So here it is. I'm not quite sure if I've done the right thing in patch 2/2, i.e. should I just use tlb_flush_mmu or export tlb_flush_mmu_tlbonly and then use it in mremap.c. Please take a look and let me know what you think, thanks!

Regards,
Aaron

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Read the cover letter in its thread