Skip to content

shallow.c improvements

Nguyễn Thái Ngọc Duy git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest6 patches 3 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6shallow.c: rename fields in paint_info to better express their purposesshallow.c+9 -90 replies
2/6shallow.c: stop abusing COMMIT_SLAB_SIZE for paint_info's memory poolsshallow.c+4 -20 replies
3/6shallow.c: make paint_alloc slightly more robustshallow.c+3 -00 replies
4/6shallow.c: avoid theoretical pointer wrap-aroundshallow.c+1 -10 replies
5/6shallow.c: bit manipulation tweaksshallow.c+4 -40 replies
6/6shallow.c: remove useless codeshallow.c+0 -40 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchRasmus Villemoes
1/6
2/6
3/6Noticed-by
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] shallow.c improvements

After staring not-so-hard and not-for-so-long at the code. This is what I come up with. Rasmus I replaced two of your commits with my own (and thank you for giving me an opportunity to refresh my memory with this stuff). The first two commits are new and the result of Jeff's observation on COMMIT_SLAB_SIZE.

You may find the description here a bit different from my explanation previously (about "exclude/shallow requests"). Well.. I was wrong. I had the recent --exclude-tag and friends in mind, but this is about clone/fetch/push from/to a shallow repository since 2013, no wonder I don't remember much about it :-D

Nguyễn Thái Ngọc Duy (4):
shallow.c: rename fields in paint_info to better express their purposes shallow.c: stop abusing COMMIT_SLAB_SIZE for paint_info's memory pools shallow.c: make paint_alloc slightly more robust
shallow.c: remove useless code

Rasmus Villemoes (2):
shallow.c: avoid theoretical pointer wrap-around shallow.c: bit manipulation tweaks

 shallow.c | 39 ++++++++++++++++++++-------------------
 1 file changed, 20 insertions(+), 19 deletions(-)
Signature · 1 line
2.8.2.524.g6ff3d78