Skip to content

tests/kms_atomic_transition add fence testing

Robert Foss intel-gfx 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest10 patches 0 repliesNew
  2. v411 patches 11 repliesSuperseded
  3. v311 patches 12 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v212 patches11 repliesSuperseded

Changes in v5 from the cover letter

Rebased on upstream/master
Added Reviewed-by: Brian Starkey <[email protected]> to all patches

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10tests/kms_atomic_transition: use igt timeout instead of blockingtests/kms_atomic_transition.c+2 -00 replies
2/10lib/igt_kms: move igt_kms_get_alt_edid() to the right placelib/igt_kms.c+17 -170 replies
3/10lib/igt_kms: export properties nameslib/igt_kms.c lib/igt_kms.h+26 -30 replies
4/10tests/kms_atomic: use global atomic properties definitionstests/kms_atomic.c+37 -860 replies
5/10lib/igt_kms: Add support for the IN_FENCE_FD propertylib/igt_kms.c lib/igt_kms.h+30 -00 replies
6/10lib/igt_kms: Add support for the OUT_FENCE_PTR propertylib/igt_kms.c lib/igt_kms.h+27 -20 replies
7/10tests/kms_atomic: stress possible fence settingstests/kms_atomic.c+177 -100 replies
8/10tests/kms_atomic_transition: add fencing parameter to run_transition_teststests/kms_atomic_transition.c+5 -50 replies
9/10tests/kms_atomic_transition: add out_fences testslib/igt_kms.c tests/kms_atomic_transition.c+165 -50 replies
10/10tests/kms_atomic_transition: add in_fences testslib/igt_kms.c tests/kms_atomic_transition.c+20 -50 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchBrian Starkey
1/10R-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH i-g-t v5 00/10] tests/kms_atomic_transition add fence testing

This series adds in/out fence testing to kms_atomic_transition test and makes some minor cleanups.

This series can be found here:
https://git.collabora.com/cgit/user/robertfoss/intel-gpu-tools.git/log/?h=fences_$VER

Changes since v4:
Rebased on upstream/master
Added Reviewed-by: Brian Starkey <[email protected]> to all patches

lib/igt_kms: Added igt_pipe_get_last_out_fence()
- Removed this patch

lib/igt_kms: Add support for the IN_FENCE_FD property
- Fixed typo in commit message

lib/igt_kms:
- Fixed description for igt_pipe_request_out_fence()
- Set pipe_obj->out_fence_fd to -1 after close() in igt_atomic_commit()
- Moved early igt_plane_set_fence_fd(plane, -1) call to igt_atomic_commit()

Changes since v3:
Rebased on upstream/master

lib/igt_kms:
- Change out_fence from int64_t to int32_t
- Fixed build error halfway in the series
- Change IN_FENCE_FD to be an int always
- Change name of out_fence to out_fence_fd
- Removed useless assert
- Fixed erroneous fence_fd check in igt_atomic_commit()
- Implemented igt_plane_set_fence_fd FD close logic
- Properly close fd in igt_atomic_prepare_plane_commit()

tests/kms_atomic:
- Changed type of out_fence_ptr to int32_t

tests/kms_atomic_transition:
- Fixed indentation errors in prepare_fencing()
- Added close() to callers of igt_plane_set_fence_fd with valid FDs
- Move change atomic_commit to earlier commit to remove inter commit changes

Changes since v2:
Rebased on upstream/master

lib/igt_kms:
- Reset plane->fence_fd to -1 during igt_atomic_prepare_plane_commit()
- Rework out_fencs_ptr to be an int64_t named out_fence
- Add igt_pipe_request_out_fence()

tests/:
- Switch to using igt_pipe_request_out_fence()
- Close out_fence fd
- Change out_fence to int64_t in run_transition_test()
- Added comments noting that two testcases are not invalid
- Added igt_pipe_get_last_out_fence() that wraps pipe->fence_out

Changes since v1:

lib/igt_kms:
- Added gtk-doc for exported symbols
- Changed integer casting to avoid potential issues
- Changed out_fence_ptr type to int64_t*
- Fixed igt_plane_set_fence_fd comment

tests/:
- Rework timeout change in commit_display()
- Extract plane_invalid_params_fence() out plane_invalid_params()
- Extract crtc_invalid_params_fence() out crtc_invalid_params()
- Prevent add igt_require_sw_sync to subtests using sw_sync

Gustavo Padovan (8):
tests/kms_atomic_transition: use igt timeout instead of blocking lib/igt_kms: move igt_kms_get_alt_edid() to the right place lib/igt_kms: export properties names tests/kms_atomic: use global atomic properties definitions lib/igt_kms: Add support for the OUT_FENCE_PTR property tests/kms_atomic: stress possible fence settings tests/kms_atomic_transition: add fencing parameter to
run_transition_tests
tests/kms_atomic_transition: add in_fences tests

Robert Foss (2):
lib/igt_kms: Add support for the IN_FENCE_FD property tests/kms_atomic_transition: add out_fences tests

 lib/igt_kms.c                 | 111 ++++++++++++---
 lib/igt_kms.h                 |  34 ++++-
 tests/kms_atomic.c            | 310 +++++++++++++++++++++++++++++-------------
 tests/kms_atomic_transition.c | 184 +++++++++++++++++++++++--
 4 files changed, 506 insertions(+), 133 deletions(-)
Signature · 6 lines
2.11.0.453.g787f75f05

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx