Support multiple listening sockets per VNC server
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest8 patches 3 repliesIn review
- v28 patches 2 repliesSuperseded
- v18 patches 9 repliesSuperseded
Changes in v3 from the cover letter
- Resolve conflicts with master for qapi schema
- Remove left-over debug statement (Eric)
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | ui: fix regression handling bare 'websocket' option to -vncui/ | +7 | 0 replies | |
| 2/8 | ui: fix reporting of VNC auth in query-vnc-serversqapi-schema.json ui/ | +74 | 0 replies | |
| 3/8 | ui: refactor VncDisplay to allow multiple listening socketsui/ ui/ | +73 | 0 replies | |
| 4/8 | ui: refactor code for populating SocketAddress from vnc_display_openqemu-options.hx ui/ | +189 | 0 replies | |
| 5/8 | ui: extract code to connect/listen from vnc_display_openui/ | +80 | 0 replies | |
| 6/8 | ui: let VNC server listen on all resolved IP addressesui/ | +43 | 0 replies | |
| 7/8 | util: add iterators for QemuOpts valuesinclude/ util/ | +28 | 0 replies | |
| 8/8 | ui: add ability to specify multiple VNC listen addressesui/ | +134 | 0 replies |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake |
|---|---|
| 1/8 | R-b |
| 2/8 | R-b |
| 3/8 | R-b |
| 4/8 | R-b |
| 5/8 | R-b |
| 6/8 | R-b |
| 7/8 | R-b |
| 8/8 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v3 0/8] Support multiple listening sockets per VNC server
Followup to
v2: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg04951.html
There are two core feature changes in this series
- If a DNS name resolves to multiple distinct IP addresses, the VNC server is now able to listen on all of them
- The -vnc argument syntax is extended to allow the 'vnc' and 'websocket' arguments to be listed multiple times. This allows a single VNC server to listen on multiple different names / addresses.
The io/ patch series that this previously depended on is now merged in git master.
Changed in v3:
- Resolve conflicts with master for qapi schema
- Remove left-over debug statement (Eric)
Changed in v2:
- Fix qapi version annotation (Eric)
- Fix misc typos in docs/commit message (Eric)
- Replace qemu_opt_get_all() with generic QemuOpt iterator API to avoid needless mem allocations
Daniel P. Berrange (8):
ui: fix regression handling bare 'websocket' option to -vnc
ui: fix reporting of VNC auth in query-vnc-servers
ui: refactor VncDisplay to allow multiple listening sockets
ui: refactor code for populating SocketAddress from vnc_display_open
ui: extract code to connect/listen from vnc_display_open
ui: let VNC server listen on all resolved IP addresses
util: add iterators for QemuOpts values
ui: add ability to specify multiple VNC listen addresses
include/qemu/option.h | 9 + qapi-schema.json | 28 ++- qemu-options.hx | 12 +- ui/vnc.c | 655 +++++++++++++++++++++++++++++++++++--------------- ui/vnc.h | 10 +- util/qemu-option.c | 19 ++ 6 files changed, 531 insertions(+), 202 deletions(-)
Signature · 1 line
2.9.3