Skip to content

Postcopy: Hugepage support

Dr. David Alan Gilbert (git) qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest16 patches 2 repliesIn review
  2. v216 patches 56 repliesSuperseded
  3. v115 patches 29 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16postcopy: Transmit ram size summary wordinclude/migration/migration.h migration/ram.c migration/savevm.c+39 -110 replies
2/16postcopy: Transmit and compare individual page sizesmigration/ram.c+17 -00 replies
3/16postcopy: Chunk discards for hugepagesmigration/ram.c+9 -80 replies
4/16exec: ram_block_discard_rangeexec.c include/exec/cpu-common.h include/migration/postcopy-ram.h +3 more+60 -581 reply
5/16postcopy: enhance ram_block_discard_range for hugepagesexec.c+20 -40 replies
6/16postcopy: Record largest page sizeexec.c include/exec/cpu-common.h include/migration/migration.h +1 more+16 -00 replies
7/16postcopy: Plumb pagesize down into place helpersinclude/migration/postcopy-ram.h migration/postcopy-ram.c migration/ram.c+40 -280 replies
8/16postcopy: Use temporary for placing zero huge pagesinclude/migration/migration.h migration/postcopy-ram.c+22 -20 replies
9/16postcopy: Load huge pages in one gomigration/ram.c+8 -50 replies
10/16postcopy: Mask fault addresses to huge page boundarymigration/postcopy-ram.c+3 -40 replies
11/16postcopy: Send whole huge pagesmigration/ram.c+5 -10 replies
12/16postcopy: Allow hugepagesmigration/postcopy-ram.c+1 -240 replies
13/16postcopy: Update userfaultfd.h headerlinux-headers/linux/userfaultfd.h+58 -90 replies
14/16postcopy: Check for userfault+hugepage featuremigration/postcopy-ram.c+11 -10 replies
15/16postcopy: Add doc about hugepages and postcopydocs/migration.txt+13 -00 replies
16/16postcopy: Add extra check for COPY functionmigration/postcopy-ram.c+4 -01 reply

Reviews trailers per patch

15 of 16 patches have a Reviewed-by or Acked-by.

PatchLaurent VivierJuan Quintela
1/16R-b R-b
2/16R-b R-b
3/16R-b R-b
4/16R-b R-b
5/16R-b R-b
6/16R-b R-b
7/16R-b R-b
8/16R-b R-b
9/16R-b R-b
10/16R-b R-b
11/16R-b R-b
12/16R-b R-b
13/16
14/16R-b R-b
15/16R-b R-b
16/16R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 00/16] Postcopy: Hugepage support

From: "Dr. David Alan Gilbert" <[email protected]>

Hi,
The existing postcopy code, and the userfault kernel
code that supports it, only works for normal anonymous memory. Kernel support for userfault on hugetlbfs has just been merged in Linus's tree for 4.11 (see 4c9a7831b11 merge)

Note that while this code supports arbitrary sized hugepages, it doesn't make sense with pages above the few-MB region, so while 2MB is fine, 1GB is probably a bad idea; this code waits for and transmits whole huge pages, and a 1GB page would take about 1 second to transfer over a 10Gbps link - which is way too long to pause the destination for.

Note: 'postcopy: Update userfaultfd.h header' is now from Paolo's recent header update run; it can be dropped as soon as Paolo's goes in.

Dave

v3
Added an extra check in 'postcopy: Add extra check for COPY function' Updates from Laurent's review:
moved the CONFIG_FALLOCATE_PUNCH_HOLE from 'ram_block_discard_range' into the following 'enhance ram_block_discard_range for hugepages' Merged the ram_block_discard_range / Fold postcopy_ram_discard_range into ram_discard_range patches
Removed the excess rcu_read_lock in ram_block_discard_range Removed a removal of a blank line in 'Mask fault address'
Updated the 'Update userfaultfd.h header' - that's now from Paolo's update

Dr. David Alan Gilbert (16):
postcopy: Transmit ram size summary word
postcopy: Transmit and compare individual page sizes
postcopy: Chunk discards for hugepages
exec: ram_block_discard_range
postcopy: enhance ram_block_discard_range for hugepages
postcopy: Record largest page size
postcopy: Plumb pagesize down into place helpers
postcopy: Use temporary for placing zero huge pages
postcopy: Load huge pages in one go
postcopy: Mask fault addresses to huge page boundary
postcopy: Send whole huge pages
postcopy: Allow hugepages
postcopy: Update userfaultfd.h header
postcopy: Check for userfault+hugepage feature
postcopy: Add doc about hugepages and postcopy
postcopy: Add extra check for COPY function

 docs/migration.txt                |  13 ++++
 exec.c                            |  83 ++++++++++++++++++++++
 include/exec/cpu-common.h         |   2 +
 include/migration/migration.h     |   3 +
 include/migration/postcopy-ram.h  |  13 ++--
 linux-headers/linux/userfaultfd.h |  67 +++++++++++++++---
 migration/migration.c             |   1 +
 migration/postcopy-ram.c          | 142 ++++++++++++++++++--------------------
 migration/ram.c                   | 109 ++++++++++++++++++-----------
 migration/savevm.c                |  32 ++++++---
 migration/trace-events            |   2 +-
 11 files changed, 319 insertions(+), 148 deletions(-)
Signature · 1 line
2.9.3